Skip to content

Conversation

Hugo-Prossaird
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) 🟢
New feature/enhancement? (use the a.x branch) 🔴
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🔴
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

I've noticed a typo in the code where a condition checks for 'undefiend' instead of 'undefined'. I'm not sure if there's an existing issue related to this, but I suggest correcting it to improve code clarity and prevent potential bugs.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.46%. Comparing base (e59dc1f) to head (a83bd62).
Report is 3 commits behind head on 6.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                6.x   #14581   +/-   ##
=========================================
  Coverage     64.46%   64.46%           
  Complexity    34613    34613           
=========================================
  Files          2271     2271           
  Lines        103439   103439           
=========================================
  Hits          66685    66685           
  Misses        36754    36754           

Copy link
Contributor

@shinde-rahul shinde-rahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.
This is good to go.

@shinde-rahul shinde-rahul added bug Issues or PR's relating to bugs javascript Pull requests that update Javascript code code-review-passed PRs which have passed code review configuration Anything related to the Mautic configuration section labels Feb 19, 2025
@npracht npracht added the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Feb 19, 2025
@escopecz escopecz added this to the 6.0.0-beta milestone Feb 26, 2025
@escopecz escopecz merged commit b702add into mautic:6.x Feb 26, 2025
17 checks passed
@RCheesley RCheesley modified the milestones: 6.0.0-beta, 6.0.0-beta2 Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review configuration Anything related to the Mautic configuration section javascript Pull requests that update Javascript code ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
Status: 🥳 Done
Development

Successfully merging this pull request may close these issues.

5 participants