Skip to content

New command to get usage of all segments #14575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Feb 24, 2025
Merged

New command to get usage of all segments #14575

merged 39 commits into from
Feb 24, 2025

Conversation

avikarshasaha
Copy link
Contributor

@avikarshasaha avikarshasaha commented Feb 10, 2025 •
edited by escopecz
Loading

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🟢
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🟢
Related user documentation PR URL mautic/user-documentation#351
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR adds new command bin/console mautic:segments:stat

Get usage data for published segments, which includes the following items:

  • Campaign entry point
  • Campaign: Change Segment Action.
  • Email include/exclude list
  • Segment filtering
  • Form actions
  • SMS inclusion/exclusion lists

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Add the published segment to the email include list
  3. Run the command to view usage data
  4. Also, look for other parts where we can use segments.

avikarshasaha and others added 30 commits February 7, 2025 20:20
@avikarshasaha
command, event, subscriber added
54a0781
@avikarshasaha
todo command formating
567770c
@avikarshasaha
SegmentStatsSubscriber for lead bundle
f99705c
@avikarshasaha
config update for subscriber
52b0ab7
@avikarshasaha
filter functionadded
7e4ca1b
@avikarshasaha
Subscriber test added
2458714
@avikarshasaha
suscriber minor fix
fc3a848
@avikarshasaha
all function covered
bec729e
@avikarshasaha
phpstan fixs
2f21585
@avikarshasaha
phpstan fixes
f69e5a0
@avikarshasaha
phpstan fixes
2011354
@avikarshasaha
phpstan fixes
5ae16f7
@avikarshasaha
change LEAD_STAT to LEAD_LIST_STAT
6b5ffa0
@avikarshasaha
change LEAD_STAT to LEAD_LIST_STAT
83ffa98
@avikarshasaha
change LEAD_STAT to LEAD_LIST_STAT
1672a36
@avikarshasaha
change LEAD_STAT to LEAD_LIST_STAT
bf66b7d
@avikarshasaha @escopecz
Update app/bundles/LeadBundle/Command/SegmentStatCommand.php
5131838 
Co-authored-by: John Linhart <admin@escope.cz>
@avikarshasaha
KeyAlreadyExistsException class added
5e0b2c0
@avikarshasaha
requested changes
0f3bdb3
@avikarshasaha
requested changes
8be48a1
@avikarshasaha
testcase fix
2a4fb0e
@avikarshasaha
SegmentStatCommand test
afbec54
@avikarshasaha
cs fixer
8239184
@avikarshasaha
phpstan fix
049d774
@avikarshasaha
assert with regex
76e32ee
@avikarshasaha
simplified code
81d3f99
@avikarshasaha
6 function added
44b9bca
@avikarshasaha
more 3 function and added those into subscriber
b8252b8
@avikarshasaha
M3.3.3 updates PHPUnit to 9.5, assertRegExp() is now deprecated, use …
722094c 
…assertMatchesRegularExpression()
@avikarshasaha
unwanted file removal
625d2e8
@escopecz escopecz added feature A new feature for inclusion in minor or major releases segments Anything related to segments unforking Used for PRs in the Acquia's unforking initiative labels Feb 10, 2025
escopecz
escopecz requested changes Feb 10, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is coming from an old PR on our fork, but let's modernize it and bullet-proof it when we have a chance in adding the new classes. It's then very costly to do afterwards when dealing with backward compatibility

@escopecz escopecz assigned avikarshasaha and unassigned escopecz Feb 13, 2025
@aarohiprasad aarohiprasad requested review from a team and rohitpavaskar and removed request for a team February 14, 2025 09:28
rohitp19
rohitp19 approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@rohitp19 rohitp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @avikarshasaha!

@aarohiprasad
Copy link
Contributor

Tested on local. Working as expected for all scenarios!
image

@aarohiprasad aarohiprasad added the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Feb 21, 2025
@aarohiprasad
Copy link
Contributor

@escopecz can you merge this?

@escopecz escopecz added this to the 6.0.0-beta milestone Feb 24, 2025
@escopecz escopecz merged commit 0a0fbdc into mautic:6.x Feb 24, 2025
17 checks passed
@RCheesley
Copy link
Member

@avikarshasaha @aarohiprasad @escopecz where are the docs on this? What command is it that users are to run? Please make a PR for the user/dev docs as appropriate, we can't just add commands and expect people to know how to use them :) Thanks!

@escopecz escopecz mentioned this pull request Feb 25, 2025
Merged
@escopecz escopecz changed the title Command to get data for segment uses New command to get usage of all segments Feb 25, 2025
@escopecz
Copy link
Member

@RCheesley good catch! I've created the docs PR here: mautic/user-documentation#351

@avikarshasaha please spend more time on the PR descriptions and docs for new features in the following PRs.

@RCheesley RCheesley modified the milestones: 6.0.0-beta, 6.0.0-beta2 Mar 5, 2025
@mautibot
Copy link
Contributor

mautibot commented Mar 6, 2025

This pull request has been mentioned on Mautic Forums. There might be relevant details there:

https://forum.mautic.org/t/announcing-mautic-6-beta-now-available-for-testing/35196/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz Awaiting requested review from escopecz

2 more reviewers

@rohitpavaskar rohitpavaskar rohitpavaskar approved these changes

@rohitp19 rohitp19 rohitp19 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@avikarshasaha avikarshasaha

Labels
feature A new feature for inclusion in minor or major releases ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged segments Anything related to segments unforking Used for PRs in the Acquia's unforking initiative
Projects
None yet
Milestone
6.0.0-beta2
Development

Successfully merging this pull request may close these issues.
7 participants
@avikarshasaha @escopecz @aarohiprasad @RCheesley @mautibot @rohitpavaskar @rohitp19