Restrict user deletion of categories associated with other resources #14567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 61bd54ae07868713b0edcab02ec9db1441f5f9da.
Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>
Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>
Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>
Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>
Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>
Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>
Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>
Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>
Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>
escopecz
requested changes
Feb 7, 2025
app/bundles/CategoryBundle/EventListener/CategorySubscriber.php
Outdated
Show resolved
Hide resolved
app/bundles/CoreBundle/Exception/RecordCanNotBeDeletedException.php
Outdated
Show resolved
Hide resolved
|
Please request the review again once the CI is green |
escopecz
approved these changes
Feb 11, 2025
rahuld-dev
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Thanks @avikarshasaha
It is working as expected.
There is another issue with Category list page it is not related to this PR.
If you delete a category you will see the category list page UI is broken.
|
That issue is recorded at #14401 |
|
This pull request has been mentioned on Mautic Forums. There might be relevant details there: https://forum.mautic.org/t/announcing-mautic-6-beta-now-available-for-testing/35196/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we restrict user deletion of categories if they are associated to other resources.
📋 Steps to test this PR: