Skip to content

Remove Factory::getParameter. #14565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

Remove Factory::getParameter. #14565

merged 1 commit into from
Feb 10, 2025

Conversation

biozshock
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🟢
Deprecations? 🟢
BC breaks? (use the c.x branch) 🟢
Automated tests included? 🟢

Description

Remove Factory::getParameter.

📋 Steps to test this PR:

  1. Code review only.

@codecov Codecov
Copy link

codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.08%. Comparing base (522e8e3) to head (65c07a3).
Report is 11 commits behind head on 6.x.

Files with missing lines Patch % Lines
app/bundles/EmailBundle/Helper/MailHelper.php 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                6.x   #14565   +/-   ##
=========================================
  Coverage     64.08%   64.08%           
+ Complexity    34533    34532    -1     
=========================================
  Files          2265     2265           
  Lines        103181   103179    -2     
=========================================
  Hits          66124    66124           
+ Misses        37057    37055    -2
Files with missing lines Coverage Δ
app/bundles/CoreBundle/Factory/MauticFactory.php 100.00% <ø> (+22.22%) ⬆️
app/bundles/EmailBundle/Helper/MailHelper.php 78.85% <0.00%> (ø)

@escopecz
Copy link
Member

escopecz commented Feb 7, 2025

It looks like PHPSTAN found one more occurence?

@escopecz escopecz added pending-feedback PR's and issues that are awaiting feedback from the author refactoring The change does not change behavior but improves the code labels Feb 7, 2025
@escopecz escopecz added this to the 6.0.0-beta milestone Feb 7, 2025
@escopecz escopecz added the has-conflicts Pull requests that cannot be merged until conflicts have been resolved label Feb 7, 2025
@biozshock biozshock force-pushed the factory-getparameter branch from d872050 to 65c07a3 Compare February 7, 2025 22:25
@biozshock
Copy link
Contributor Author

@escopecz was removed by another PR. Should be ok now.

@escopecz escopecz removed pending-feedback PR's and issues that are awaiting feedback from the author has-conflicts Pull requests that cannot be merged until conflicts have been resolved labels Feb 10, 2025
escopecz
escopecz approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no more occurrences and the changes look good 👍

Thank you!

@escopecz escopecz added the code-review-passed PRs which have passed code review label Feb 10, 2025
@escopecz escopecz merged commit 01ab521 into mautic:6.x Feb 10, 2025
17 checks passed
@RCheesley RCheesley modified the milestones: 6.0.0-beta, 6.0.0-beta2 Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
code-review-passed PRs which have passed code review refactoring The change does not change behavior but improves the code
Projects
None yet
Milestone
6.0.0-beta2
Development

Successfully merging this pull request may close these issues.
3 participants
@biozshock @escopecz @RCheesley