Skip to content

Conversation

avikarshasaha
Copy link
Contributor

@avikarshasaha avikarshasaha commented Feb 5, 2025

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🟢
Deprecations? 🟢
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🔴
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

UUID implementation. This is necessary for global identification of entities for the campaign library:

#14504

The UUID will be used to decide whether an entity should be updated or inserted during the import of entities.


📋 Steps to test this PR:

  1. Run bin/console doctrine:migrations:migrate to apply the migration.
  2. You should see in the changed entities/tables like reports, pages, emails and so on that there is new UUID column in the table with filled in hash.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.67%. Comparing base (eef5281) to head (28f30d3).
Report is 28 commits behind head on 6.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                6.x   #14558      +/-   ##
============================================
+ Coverage     64.65%   64.67%   +0.01%     
  Complexity    34675    34675              
============================================
  Files          2273     2273              
  Lines        103569   103593      +24     
============================================
+ Hits          66965    66995      +30     
+ Misses        36604    36598       -6     
Files with missing lines Coverage Δ
app/bundles/AssetBundle/Entity/Asset.php 77.03% <100.00%> (+0.05%) ⬆️
app/bundles/CampaignBundle/Entity/Campaign.php 80.64% <100.00%> (+0.08%) ⬆️
app/bundles/CampaignBundle/Entity/Event.php 90.99% <100.00%> (+0.02%) ⬆️
app/bundles/CategoryBundle/Entity/Category.php 95.00% <100.00%> (+0.08%) ⬆️
app/bundles/ChannelBundle/Entity/Channel.php 84.74% <100.00%> (+0.26%) ⬆️
app/bundles/ChannelBundle/Entity/Message.php 87.01% <100.00%> (+0.17%) ⬆️
app/bundles/CoreBundle/Entity/UuidTrait.php 75.00% <100.00%> (+75.00%) ⬆️
...les/DynamicContentBundle/Entity/DynamicContent.php 74.67% <100.00%> (+0.16%) ⬆️
app/bundles/EmailBundle/Entity/Email.php 92.03% <100.00%> (+0.01%) ⬆️
app/bundles/FormBundle/Entity/Action.php 90.27% <100.00%> (+0.13%) ⬆️
... and 15 more

@escopecz escopecz added enhancement Any improvement to an existing feature or functionality unforking Used for PRs in the Acquia's unforking initiative labels Feb 5, 2025
@avikarshasaha avikarshasaha requested review from a team and dadarya0 and removed request for a team February 12, 2025 12:16
@escopecz escopecz added the pending-feedback PR's and issues that are awaiting feedback from the author label Feb 12, 2025
@escopecz escopecz mentioned this pull request Feb 24, 2025
1 task
@escopecz escopecz self-requested a review March 3, 2025 13:13
Copy link

composer.lock

Package changes

Package Operation From To About
symfony/serializer add - v6.4.18 view code - License: MIT License

Settings · Docs · Powered by Private Packagist

Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the changes I requested, tested the migration and the UUID columns were created and filled in.

@escopecz escopecz added pending-test-confirmation PR's that require one test before they can be merged code-review-passed PRs which have passed code review user-testing-passed PRs which have been successfully tested by the required number of people. and removed pending-feedback PR's and issues that are awaiting feedback from the author labels Mar 3, 2025
@levente999 levente999 self-requested a review March 3, 2025 15:02
@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Mar 3, 2025
@escopecz escopecz added this to the 6.0.0-RC milestone Mar 3, 2025
@escopecz escopecz merged commit bad5c51 into mautic:6.x Mar 3, 2025
18 checks passed
@escopecz escopecz removed the request for review from dadarya0 March 3, 2025 15:16
@mautibot
Copy link
Contributor

mautibot commented May 1, 2025

This pull request has been mentioned on Mautic Forums. There might be relevant details there:

https://forum.mautic.org/t/issue-with-logging-in-to-mautic-6-0-after-upgrade-from-5-2-5/35610/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged unforking Used for PRs in the Acquia's unforking initiative user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants