Skip to content

[Form theme] Chord #14547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 24, 2025
Merged

[Form theme] Chord #14547

merged 7 commits into from
Feb 24, 2025

Conversation

andersonjeccel
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🟢
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🔴
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR adds a minimalist form theme

Features:

  • Checkboxes
  • Radio groups
  • Fields in general
  • Hover effects to aid in UX

Screenshot From 2025-02-03 10-25-36

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open Forms > New
  3. Pick Chord in "Theme"
  4. Create some fields in the builder
  5. Save
  6. Preview

@andersonjeccel andersonjeccel requested review from a team, mchojrin and laurielim February 3, 2025 13:31
@andersonjeccel andersonjeccel self-assigned this Feb 3, 2025
@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging user-experience Anything related to related to workflows, feedback, and navigation enhancement Any improvement to an existing feature or functionality forms Anything related to forms themes Anything related to themes labels Feb 3, 2025
@andersonjeccel andersonjeccel added this to the 6.0.0-beta milestone Feb 3, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.26%. Comparing base (6dfb228) to head (2c8124b).
Report is 1 commits behind head on 6.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                6.x   #14547   +/-   ##
=========================================
  Coverage     64.26%   64.26%           
  Complexity    34569    34569           
=========================================
  Files          2268     2268           
  Lines        103258   103258           
=========================================
  Hits          66354    66354           
  Misses        36904    36904

imaabasiee
imaabasiee reviewed Feb 5, 2025
View reviewed changes
Copy link

@imaabasiee imaabasiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A review for this PR: #14547

The chord theme works just as expected. It is simple and allows for the following: Checkboxes, Radio groups, Fields in general and Hover effects to aid in UX. But I noticed I could not untick the radio group buttons and it is not a required field. If this is not a bug, then the pr is ready to go.

Here is a link to what I tested https://www.loom.com/share/1e5e3766d51d4261b288a776d6f6ca0b?sid=d334e404-b9e5-4c56-875c-8578cd7cf7a1

shinde-rahul
shinde-rahul approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@shinde-rahul shinde-rahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!!!

Thanks @andersonjeccel!!!

@shinde-rahul shinde-rahul added code-review-passed PRs which have passed code review and removed code-review-needed PR's that require a code review before merging labels Feb 6, 2025
@shinde-rahul
Copy link
Contributor

@imaabasiee, the radio groups work like that.

imaabasiee
imaabasiee approved these changes Feb 6, 2025
View reviewed changes
Copy link

@imaabasiee imaabasiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, cool @shinde-rahul

Well done @andersonjeccel

kuzmany
kuzmany approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me 👍

matbcvo
matbcvo reviewed Feb 7, 2025
View reviewed changes
matbcvo
matbcvo reviewed Feb 11, 2025
View reviewed changes
@andersonjeccel andersonjeccel mentioned this pull request Feb 21, 2025
Merged
@matbcvo matbcvo added pending-feedback PR's and issues that are awaiting feedback from the author has-conflicts Pull requests that cannot be merged until conflicts have been resolved labels Feb 21, 2025
RCheesley
RCheesley reviewed Feb 21, 2025
View reviewed changes
@RCheesley
Copy link
Member

@andersonjeccel will you eventually add an email and landing page theme for this one? Or is it destined to only be a form theme?

@RCheesley RCheesley removed the has-conflicts Pull requests that cannot be merged until conflicts have been resolved label Feb 24, 2025
@RCheesley RCheesley added user-testing-passed PRs which have been successfully tested by the required number of people. ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed ready-to-test PR's that are ready to test pending-feedback PR's and issues that are awaiting feedback from the author labels Feb 24, 2025
@RCheesley
Copy link
Member

I've added the close PRs workflow file as it was missing from the directory.

@RCheesley RCheesley merged commit e4e3649 into mautic:6.x Feb 24, 2025
18 checks passed
@andersonjeccel andersonjeccel deleted the chord-theme branch February 24, 2025 14:10
@RCheesley RCheesley modified the milestones: 6.0.0-beta, 6.0.0-beta2 Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbcvo matbcvo matbcvo left review comments

@RCheesley RCheesley RCheesley left review comments

@kuzmany kuzmany kuzmany approved these changes

@mchojrin mchojrin Awaiting requested review from mchojrin mchojrin was automatically assigned from mautic/ux-ui-tiger-team

@laurielim laurielim Awaiting requested review from laurielim laurielim was automatically assigned from mautic/ux-ui-tiger-team

+2 more reviewers

@shinde-rahul shinde-rahul shinde-rahul approved these changes

@imaabasiee imaabasiee imaabasiee approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@andersonjeccel andersonjeccel

Labels
code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality forms Anything related to forms ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged T1 Low difficulty to fix (issue) or test (PR) themes Anything related to themes user-experience Anything related to related to workflows, feedback, and navigation user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Open Source Fridays
Status: 🥳 Done
UX/UI Tiger Team
Status: Done
Milestone
6.0.0-beta2
Development

Successfully merging this pull request may close these issues.
6 participants
@andersonjeccel @shinde-rahul @RCheesley @kuzmany @matbcvo @imaabasiee