Skip to content

Removed MauticFactory::getKernel. #14435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

Removed MauticFactory::getKernel. #14435

merged 1 commit into from
Jan 7, 2025

Conversation

biozshock
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🟢
Deprecations? 🟢
BC breaks? (use the c.x branch) 🟢
Automated tests included? 🟢

Description

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open https://domain/mtc.js - that's the only place where the removed method was used.

@biozshock biozshock force-pushed the factory-getKernel branch 3 times, most recently from 51d5997 to be2dcea Compare January 7, 2025 00:21
@codecov Codecov
Copy link

codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.65%. Comparing base (8558601) to head (e1cb1de).
Report is 2 commits behind head on 6.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                6.x   #14435      +/-   ##
============================================
- Coverage     63.65%   63.65%   -0.01%     
+ Complexity    34640    34639       -1     
============================================
  Files          2277     2277              
  Lines        103625   103622       -3     
============================================
- Hits          65965    65962       -3     
  Misses        37660    37660
Files with missing lines Coverage Δ
app/bundles/CoreBundle/Controller/JsController.php 100.00% <100.00%> (ø)
app/bundles/CoreBundle/Factory/MauticFactory.php 59.09% <ø> (-1.78%) ⬇️

@escopecz escopecz self-requested a review January 7, 2025 09:50
escopecz
escopecz approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct. All usages of this method were replaced and I tested that when I access https://mautic-community.ddev.site/mtc.js then the $kernelDebug value is the same as in my .env.local file. Thank you! 👍

@escopecz escopecz added refactoring The change does not change behavior but improves the code code-review-passed PRs which have passed code review user-testing-passed PRs which have been successfully tested by the required number of people. labels Jan 7, 2025
@escopecz escopecz added this to the 6.0 milestone Jan 7, 2025
@escopecz escopecz merged commit 2d93ec8 into mautic:6.x Jan 7, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
code-review-passed PRs which have passed code review refactoring The change does not change behavior but improves the code user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
None yet
Milestone
6.0.0-alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@biozshock @escopecz