feat: Show Building if a segment is new or updated but not yet rebuilt #14431
Conversation
|
I have some other work pending that hopefully I can follow up with later. Specifically there is one where I made |
|
Will check tests in some time. Looks like I was gonna add test for the class changes in the AJX and forgot! Will look at it when I can but welcome feedback in the interim |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 6.x #14431 +/- ##
============================================
- Coverage 63.74% 63.73% -0.01%
- Complexity 34646 34651 +5
============================================
Files 2279 2279
Lines 103739 103746 +7
============================================
+ Hits 66126 66127 +1
- Misses 37613 37619 +6
|
61cf652 to
44c6718
Compare
|
Fixed the tests and added missing CSS classes test. |
|
Hey @driskell, could you rebase your branch and change the target to 6.x? 5.2 is receiving only bug fixes at this time |
44c6718 to
1d9a78d
Compare
Ah is there no 5.3 due then? (I targeted 5.x not 5.2) I rebased to 6.x anyway but it looks like it cleanly applies to both with exception of 1 line in the AjaxController so easy to cherry if there was going to be a 5.3 and it was deemed useful. |
|
@driskell We're moving all new enhancements and features to 6.x without 5.3. As the release calendar is many months late, Mautic will skip some versions until we get up to date :) |
|
@driskell Re. the failing tests, could you check PHUnit? |
|
I think bogus - looks like a random fail due to time or something and the baseline never was changed. I’ll push again to force rerun as perhaps it ran it on the push before I changed the base and didn’t rerun |
1d9a78d to
36d9f12
Compare
|
@andersonjeccel Looks good now! btw do you know is there a way for me to get onto the development slack? I think the register is locked for external users at the moment. |
|
I think the needs-rebase tag can be removed now |
|
@driskell btw, could you ping me in the Mautic Slack? I'm there as |
Yes it will - the code changes per code review so needs a retest |
4e7b8fa to
78827dd
Compare
|
Please ensure that this is documented in the user docs! Thanks! |
|
@escopecz I finished the code review requested changes and also now finished testing it here and it works as before still. 👍 |
|
I tested it on my side, and it seems to be working as expected 👍 |
|
@driskell can you please write a paragraph to the docs about this feature so this could be merged? |
I raised a quick PR here: mautic/user-documentation#349 |
|
Thanks! |
|
This pull request has been mentioned on Mautic Forums. There might be relevant details there: https://forum.mautic.org/t/announcing-mautic-6-beta-now-available-for-testing/35196/1 |
Docs PR: mautic/user-documentation#349
Description
When creating a new segment with filters, it displays immediately "No Contacts". This can be confusing to new users as it does not indicate there is an action waiting to build the new segment. Additionally, once build begins, you will see "123 Contacts" - however, the build may not be finished yet. The only way a user can know it is finished is to keep refreshing the page until the count does not change for a minute. It's not really easy to know if it's completed.
Similarly, when editing a segment, for example if you realised you captured too many due to a typo, after saving you just see the same contact count. There is no indication that a rebuild is waiting that might substantially change the count (even potentially reducing it to "No Contacts"). Neither is there indication of progress or when it completes. So again you are left refreshing the page waiting for it to stop changing. In cases where the change is 0 it is then even more difficult as you cannot know if it just didn't get around to rebuilding yet or if it did rebuild but it was 0 change because of an error in your filters.
This PR adds in additional statuses, bringing the list to:
Screenshot for a new segment:
After
mautic:segments:updatepasses over it:After it is modified by a user:
This then returns to the previous screen after
mautic:segments:updatepasses over it.📋 Steps to test this PR:
mautic:segments:update. It will now display No Contacts or X Contacts depending on the filters.mautic:segments:update. It will now display No Contacts or X Contacts depending on the filters.I did deprecate the
Mautic\LeadBundle\Entity\LeadList::initializeLastBuiltDateas we need to allownulllast built date for new segments. Previously it would be set to a last built date of now for a new segment which was incorrect. The field was always nullable though so it's hard to say how bad a BC change this would be. I left the method in place as it was public, and marked it@deprecated.My sponsoring organisation here is Other Media