Skip to content

Removed unused methods from MauticFactory. #14400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2024
Merged

Removed unused methods from MauticFactory. #14400

merged 2 commits into from
Dec 20, 2024

Conversation

biozshock
Copy link
Contributor

@biozshock biozshock commented Dec 18, 2024 •
edited
Loading

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🟢
Deprecations? 🔴
BC breaks? (use the c.x branch) 🟢
Automated tests included? 🟢

Description

Removed unused by Mautic getDebugMode, getMauticBundles, getPluginBundles, getBundleConfig, getUser, getTranslator, getRouter, getLocalConfigFile, getEnvironment, getIpAddress from deprecated MauticFactory.

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)

@biozshock biozshock force-pushed the factory-remove-unused branch 2 times, most recently from 6d979c8 to ae3d5b2 Compare December 19, 2024 01:04
@biozshock biozshock force-pushed the factory-remove-unused branch from ae3d5b2 to d3f34e0 Compare December 20, 2024 09:09
@escopecz escopecz self-requested a review December 20, 2024 10:00
@escopecz escopecz added enhancement Any improvement to an existing feature or functionality refactoring The change does not change behavior but improves the code labels Dec 20, 2024
@escopecz escopecz added this to the 6.0 milestone Dec 20, 2024
escopecz
escopecz approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I couldn't find usage of these removed methods either 👍 Thanks!

@escopecz escopecz merged commit d754a29 into mautic:6.x Dec 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
enhancement Any improvement to an existing feature or functionality refactoring The change does not change behavior but improves the code
Projects
None yet
Milestone
6.0.0-alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@biozshock @escopecz