Skip to content

Remove MauticFactory::getMailer. #14494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2025
Merged

Remove MauticFactory::getMailer. #14494

merged 1 commit into from
Jan 22, 2025
+6 −18

Conversation

biozshock
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🟢
Deprecations? 🟢
BC breaks? (use the c.x branch) 🟢
Automated tests included? 🟢

Description

Remove deprecated MauticFactory::getMailer.

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Create an Email template on the page: https://host/s/emails
  3. Check the only usage of the method: https://host/s/ajax?action=lead:getEmailTemplate&template=[Email ID]

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.03%. Comparing base (29b01fe) to head (9463420).
Report is 44 commits behind head on 6.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                6.x   #14494      +/-   ##
============================================
- Coverage     64.03%   64.03%   -0.01%     
+ Complexity    34653    34652       -1     
============================================
  Files          2287     2287              
  Lines        103717   103714       -3     
============================================
- Hits          66418    66415       -3     
  Misses        37299    37299
Files with missing lines Coverage Δ
app/bundles/CoreBundle/Factory/MauticFactory.php 44.00% <ø> (-4.15%) ⬇️
...p/bundles/LeadBundle/Controller/AjaxController.php 18.99% <100.00%> (-0.18%) ⬇️

escopecz
escopecz approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no other usages. Thank you! 👍

@escopecz escopecz added refactoring The change does not change behavior but improves the code code-review-passed PRs which have passed code review labels Jan 22, 2025
@escopecz escopecz added this to the 6.0 milestone Jan 22, 2025
@escopecz escopecz merged commit 8aea46c into mautic:6.x Jan 22, 2025
16 of 17 checks passed
@RCheesley RCheesley added deprecation Includes deprecations and removed deprecation Includes deprecations labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
code-review-passed PRs which have passed code review refactoring The change does not change behavior but improves the code
Projects
None yet
Milestone
6.0.0-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@biozshock @escopecz @RCheesley