Skip to content

Allowing plugins to output custom content on more places #14488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 23, 2025
Merged

Allowing plugins to output custom content on more places #14488

merged 4 commits into from
Jan 23, 2025

Conversation

rohitpavaskar
Copy link
Contributor

@rohitpavaskar rohitpavaskar commented Jan 21, 2025 •
edited
Loading

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🔴
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🔴
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

needed changes to make the code extendable and to support my plugin

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Verify it does not break anything.

@rohitpavaskar rohitpavaskar changed the base branch from 6.x to 5.2 January 21, 2025 10:36
@rohitpavaskar rohitpavaskar requested review from a team and fedys and removed request for a team January 21, 2025 11:07
@rohitpavaskar rohitpavaskar added the unforking Used for PRs in the Acquia's unforking initiative label Jan 21, 2025
@escopecz
Copy link
Member

@rohitp19 since this is not a bug fix it should be opened against the 6.x (feature branch). Let me look into the failing e2e tests. It seems to be an issue on the 5.2 branch

escopecz
escopecz requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny suggestion. Otherwise I see this very helpful for plugin developers who will be able to hook into various twig templates.

@escopecz escopecz added enhancement Any improvement to an existing feature or functionality plugin Anything related to plugins labels Jan 21, 2025
@kuzmany
Copy link
Member

kuzmany commented Jan 22, 2025

Why can't we use __context instead of mauticTemplateVars as we do in many other places?
{{ customContent('left.section.bottom', _context) }}

mautic/app/bundles/CampaignBundle/Resources/views/Campaign/details.html.twig

Line 223 in 4610a2c

{{ customContent('right.section.top', _context) }}

@rohitpavaskar rohitpavaskar force-pushed the custom_content_invoke_on_list_and_view branch from 972ba81 to 1ad2b02 Compare January 23, 2025 05:36
@rohitpavaskar rohitpavaskar changed the base branch from 5.2 to 6.x January 23, 2025 05:36
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.04%. Comparing base (306d771) to head (2316f3f).
Report is 5 commits behind head on 6.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                6.x   #14488   +/-   ##
=========================================
  Coverage     64.04%   64.04%           
  Complexity    34647    34647           
=========================================
  Files          2287     2287           
  Lines        103705   103705           
=========================================
  Hits          66413    66413           
  Misses        37292    37292

fedys
fedys approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@fedys fedys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rohitp19!

@escopecz escopecz added code-review-passed PRs which have passed code review user-testing-passed PRs which have been successfully tested by the required number of people. labels Jan 23, 2025
@escopecz escopecz added this to the 6.0 milestone Jan 23, 2025
@escopecz escopecz merged commit b36cc9d into mautic:6.x Jan 23, 2025
17 checks passed
@escopecz escopecz changed the title Custom content invoke on list and view Allowing plugins to output custom content on more places Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuzmany kuzmany kuzmany approved these changes

@fedys fedys fedys approved these changes

@escopecz escopecz Awaiting requested review from escopecz

Assignees
No one assigned
Labels
code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality plugin Anything related to plugins unforking Used for PRs in the Acquia's unforking initiative user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
None yet
Milestone
6.0.0-alpha
Development

Successfully merging this pull request may close these issues.
5 participants
@rohitpavaskar @escopecz @kuzmany @fedys @rohitp19