Skip to content

Fix form subscriber test #14473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 17, 2025
Merged

Fix form subscriber test #14473

merged 4 commits into from
Jan 17, 2025

Conversation

fedys
Copy link
Member

@fedys fedys commented Jan 17, 2025 •
edited
Loading

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🔴
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🔴
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR fixes the following failing test:

1) FormBundle\Tests\EventListener\FormSubscriberTest::testOnFormSubmitActionRepost
08:22:47  Mautic\FormBundle\Exception\ValidationException: <HTML><HEAD>
08:22:47  <TITLE>Access Denied</TITLE>
08:22:47  </HEAD><BODY>
08:22:47  <H1>Access Denied</H1>
08:22:47   
08:22:47  You don't have permission to access "http&#58;&#47;&#47;example&#46;com&#47;" on this server.<P>
08:22:47  Reference&#32;&#35;18&#46;8af6d517&#46;1736925661&#46;2990a35b
08:22:47  <P>https&#58;&#47;&#47;errors&#46;edgesuite&#46;net&#47;18&#46;8af6d517&#46;1736925661&#46;2990a35b</P>
08:22:47  </BODY>
08:22:47  </HTML>

📋 Steps to test this PR:

  1. This PR does not touch any production code. Once the pipeline is green, the PR is considered tested.

@fedys fedys requested a review from escopecz January 17, 2025 13:33
@escopecz
Copy link
Member

escopecz commented Jan 17, 2025 •
edited
Loading

@fedys the issue with CS fixer suggests that your base branch isn't up to date. Git thinks there are other changes in files that you didn't touch. Please try to rebase on latest. Also, could you push the same commit (PR) against the 5.2 branch? It has the same issue and bug fixes are against that branch.

@escopecz escopecz added this to the 6.0 milestone Jan 17, 2025
@escopecz escopecz added bug Issues or PR's relating to bugs automated-tests Anything related to unit, functional or e2e tests labels Jan 17, 2025
@escopecz
Copy link
Member

5.2 version is here: #14474

@fedys you rock!

@fedys
Copy link
Member Author

fedys commented Jan 17, 2025

5.2 PR: #14474.

escopecz
escopecz approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@escopecz escopecz merged commit 9b7be3d into mautic:6.x Jan 17, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
automated-tests Anything related to unit, functional or e2e tests bug Issues or PR's relating to bugs
Projects
None yet
Milestone
6.0.0-alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@fedys @escopecz