Codecov Report

Attention: Patch coverage is 70.37037% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.07%. Comparing base (7cfae6f) to head (8f456dc).
Report is 37 commits behind head on 6.x.

@@            Coverage Diff             @@
##                6.x   #14450    +/-   ##
==========================================
  Coverage     64.07%   64.07%            
+ Complexity    34677    34528   -149     
==========================================
  Files          2287     2265    -22     
  Lines        103786   103175   -611     
==========================================
- Hits          66499    66108   -391     
+ Misses        37287    37067   -220     

When I tried to test this by opening an old email (the test one from sample data) which used the blank theme, I am greeted with a partly blank screen with no builder or editor.

I think for these old theme emails we should perhaps be opening them in the GrapesJS builder as an HTML email?

Here's a screencast: https://app.screencastify.com/v3/watch/Nmlm5epI7LeAY7zBEDdn

The blank theme should support the GrapesJS builder however it seems like it's loading in the old one:

@RCheesley I cannot reproduce:

Please make sure you've run npm ci and bin/console mautic:assets:generate and also clear assets in your browser. Perhaps there is something cached.

I've run npm ci and regenerated assets (I'm in dev mode, locally) and still getting it opening in the old browser :( Also tried this in Gitpod to rule out funky stuff with my local environment.

@escopecz can you please try in Gitpod so we have reproducible environments with the sample data?

I don't think it's the old browser that's opening. I think it's the GrapesJS builder but having some issue with the content. I'll try to use the sample data as you do when I find a free minute.

I can reproduce @RCheesley's issue on Gitpod with sample data loaded.

JavaScript error appears in the console when opening the Builder:

Uncaught Error: No valid HTML template found
    at O.getOriginalContentHtml (builder.js?v05d545f1:10:2514)
    at tc.initEmailHtml (builder.js?v05d545f1:85:5826)
    at tc.initGrapesJS (builder.js?v05d545f1:85:3225)
    at Mautic.launchBuilder (builder.js?v05d545f1:85:9673)
    at HTMLButtonElement.onclick (1:1:8)
    at Object.trigger (jquery.js?v05d545f1:8635:27)
    at HTMLButtonElement.<anonymous> (jquery.js?v05d545f1:8707:17)
    at Function.each (jquery.js?v05d545f1:383:19)
    at jQuery.fn.init.each (jquery.js?v05d545f1:205:17)
    at jQuery.fn.init.trigger (jquery.js?v05d545f1:8706:15)

Also I tested it on the 6.x branch, encountered the same issue. The builder opens, but still broken and the same error appears in the console. I can't close the builder or save, it's stuck.

@RCheesley do you mind merging this and fixing the sample data issue later as it wasn't introduced in this PR?

@escopecz sure let's raise a separate issue so we don't lose track of it.

Flagged up the issue in #14563 to be fixed separately.