Skip to content

Removed getSecurity and getSecurityContext from MauticFactory. #14399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2025
Merged

Removed getSecurity and getSecurityContext from MauticFactory. #14399

merged 1 commit into from
Jan 2, 2025

Conversation

biozshock
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🟢
Deprecations? 🔴
BC breaks? (use the c.x branch) 🟢
Automated tests included? 🟢

Description

Removed getSecurity and getSecurityContext from deprecated MauticFactory.

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)

@biozshock biozshock force-pushed the factory-getsecurity branch 2 times, most recently from 1383a22 to 8ee9c80 Compare December 20, 2024 09:08
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.57%. Comparing base (a264399) to head (6d8cb74).
Report is 13 commits behind head on 6.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                6.x   #14399   +/-   ##
=========================================
  Coverage     63.57%   63.57%           
+ Complexity    34688    34686    -2     
=========================================
  Files          2281     2281           
  Lines        103775   103771    -4     
=========================================
- Hits          65976    65974    -2     
+ Misses        37799    37797    -2
Files with missing lines Coverage Δ
app/bundles/CoreBundle/Factory/MauticFactory.php 67.79% <ø> (+1.12%) ⬆️
...es/LeadBundle/Controller/Api/ListApiController.php 63.95% <100.00%> (ø)

@escopecz escopecz added enhancement Any improvement to an existing feature or functionality refactoring The change does not change behavior but improves the code labels Dec 20, 2024
@escopecz escopecz added this to the 6.0 milestone Dec 20, 2024
@escopecz escopecz self-requested a review December 20, 2024 10:04
@escopecz
Copy link
Member

@biozshock can you please resolve the conflicts? Otherwise it's good to go

@escopecz escopecz added the has-conflicts Pull requests that cannot be merged until conflicts have been resolved label Dec 20, 2024
@biozshock
Copy link
Contributor Author

@escopecz done. There's another MR to be reviewed that removes getHelper: #14382. And i'm working on the other methods of factory to remove it completely hopefully before 6.0

escopecz
escopecz approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are correct. Thank you!

@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged code-review-passed PRs which have passed code review and removed has-conflicts Pull requests that cannot be merged until conflicts have been resolved labels Dec 28, 2024
@escopecz escopecz merged commit 08e24a3 into mautic:6.x Jan 2, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged refactoring The change does not change behavior but improves the code
Projects
None yet
Milestone
6.0.0-alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@biozshock @escopecz