Skip to content

[UI] Refactor user preferences to use database instead of localStorage #14398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 6, 2025
Merged

[UI] Refactor user preferences to use database instead of localStorage #14398

merged 3 commits into from
Jan 6, 2025

Conversation

andersonjeccel
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🟢
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🔴
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR replaces localStorage for saving user preferences to use the database instead.

It aims to provide a consistent experience for users when switching accounts and devices.

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open Accounts > Appearance
  3. Change themes and related stuff, see everything seems normal as before

@andersonjeccel andersonjeccel self-assigned this Dec 18, 2024
@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging refactoring The change does not change behavior but improves the code labels Dec 18, 2024
@andersonjeccel andersonjeccel added this to the 6.0 milestone Dec 18, 2024
escopecz
escopecz approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues in the code and it changing a theme works nicely. I confirm that it is stored in the database now. 👍

@escopecz escopecz added pending-test-confirmation PR's that require one test before they can be merged code-review-passed PRs which have passed code review user-testing-passed PRs which have been successfully tested by the required number of people. and removed ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging labels Dec 19, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.65%. Comparing base (449afd6) to head (6a9f52c).
Report is 25 commits behind head on 6.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                6.x   #14398   +/-   ##
=========================================
  Coverage     63.64%   63.65%           
- Complexity    34639    34640    +1     
=========================================
  Files          2276     2277    +1     
  Lines        103610   103625   +15     
=========================================
+ Hits          65946    65965   +19     
+ Misses        37664    37660    -4
Files with missing lines Coverage Δ
...ndles/UserBundle/Form/Type/UserPreferencesType.php 100.00% <100.00%> (ø)
app/bundles/UserBundle/Form/Type/UserType.php 98.43% <100.00%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

@andersonjeccel andersonjeccel requested a review from kuzmany January 3, 2025 18:01
kuzmany
kuzmany approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did basic tests.
Seems work for me 👍

@andersonjeccel andersonjeccel added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Jan 4, 2025
@escopecz escopecz merged commit 8558601 into mautic:6.x Jan 6, 2025
17 checks passed
@andersonjeccel andersonjeccel deleted the refactor-user-preferences branch January 6, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuzmany kuzmany kuzmany approved these changes

@escopecz escopecz escopecz approved these changes

Assignees

@andersonjeccel andersonjeccel

Labels
code-review-passed PRs which have passed code review ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged refactoring The change does not change behavior but improves the code T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Open Source Fridays
Archived in project
Milestone
6.0.0-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@andersonjeccel @kuzmany @escopecz