Enabling Searching Contacts and Companies by Custom Field Values Without Field Alias Prefix #14393
Conversation
|
This pull request has been mentioned on Mautic Forums. There might be relevant details there: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 6.x #14393 +/- ##
============================================
+ Coverage 64.19% 64.21% +0.02%
- Complexity 34563 34566 +3
============================================
Files 2268 2268
Lines 103251 103272 +21
============================================
+ Hits 66278 66318 +40
+ Misses 36973 36954 -19
|
Co-authored-by: John Linhart <jan@linhart.email>
|
For Contacts it looks good and works but for companies I can't even create a custom Field. |
|
I think @andersonjeccel suggestion is very correct. Now we will have indexable and searchable. Almost same toggle. Indexable is dev term, we shouldn't use it. |
|
I agree that this is too technical configuration to have in the UI. I was playing with an idea to configure the indexes automatically based on the usage in the segment filters but my teammates didn't like the idea. It also couldn't work for other areas like search or repeating API queries. I like the idea that Zdeno described. Perhaps 1 toggle is all we need. |
|
Okay. I'll update the code to have one flag instead of two. Thanks. |
|
@escopecz @kuzmany @andersonjeccel, please review the changes. |
| @@ -279,7 +278,8 @@ mautic.lead.field.form.properties.lookup="Lookup values" | |||
| mautic.lead.field.form.properties.numberprecision="Precision" | |||
| mautic.lead.field.form.properties.numberrounding="Rounding mode" | |||
| mautic.lead.field.form.properties.select="Options" | |||
| mautic.lead.field.form.isIndex.tooltip="Making this field indexable may improve search performance. %indexCount% indexes out of %maxCount% have been used." | |||
| mautic.lead.field.indexable="Add to Search Index" | |||
There was a problem hiding this comment.
| mautic.lead.field.indexable="Add to Search Index" | |
| mautic.lead.field.indexable="Available in Search " |
@andersonjeccel, Please help me with the label.
There was a problem hiding this comment.
I think this is better - available in search sounds good.
There was a problem hiding this comment.
I'm experiencing the same as @Bastian2718 when creating a company custom field with this setting - it does not happen with the default 6.x branch, only with this PR applied.
|
@RCheesley, I have updated the branch with 6.x. |
|
This pull request has been mentioned on Mautic Forums. There might be relevant details there: https://forum.mautic.org/t/announcing-mautic-6-beta-now-available-for-testing/35196/1 |
Description
Enabling Searching Contacts and Companies by Custom Field Values Without Field Alias Prefix
Problem Statement:
Currently, Mautic's search functionality only allows users to search for contacts or companies directly based on the values saved in custom fields, specifying the field alias and a colon (e.g., client_id:my-client-id).
📋 Steps to test this PR:
Add to Search Indexflag