Skip to content

Fixing more places getting non-scalar values from request in Symfony 6 #14384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 18, 2024
Merged

Fixing more places getting non-scalar values from request in Symfony 6 #14384

merged 4 commits into from
Dec 18, 2024

Conversation

escopecz
Copy link
Member

Q A
Bug fix? (use the a.b branch) 🔴🟢
New feature/enhancement? (use the a.x branch) 🔴🟢
Deprecations? 🔴🟢
BC breaks? (use the c.x branch) 🔴🟢
Automated tests included? 🔴🟢
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

@laurielim reported on Slack this error:

Uncaught PHP Exception Symfony\Component\HttpKernel\Exception\BadRequestHttpException: "Input value "focus" contains a non-scalar value." at /var/www/html/vendor/symfony/http-kernel/HttpKernel.php line 83

This PR fixes creating a new Focus items and I went through the rest of the code base and fixed it on other places where it was obvious from the code that the value is suppose to be an array (non-scalar value)

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Create a new Focus item
  3. Test wherever we use date ranges like in dashboards, reports, carts on various detail pages that it works as expected.

@escopecz escopecz added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging focus-items Anything related to focus items labels Dec 17, 2024
@laurielim laurielim self-requested a review December 17, 2024 11:40
laurielim
laurielim approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@laurielim laurielim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focus point can now be created, also tested Landing page and Report

@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 63.41%. Comparing base (1eac34e) to head (2f57476).
Report is 121 commits behind head on 6.x.

Files with missing lines Patch % Lines
...boardBundle/Controller/Api/WidgetApiController.php 0.00% 2 Missing ⚠️
...es/FormBundle/Controller/Api/FormApiController.php 0.00% 2 Missing ⚠️
app/bundles/DashboardBundle/Dashboard/Widget.php 0.00% 1 Missing ⚠️
...p/bundles/FormBundle/Controller/FormController.php 0.00% 1 Missing ⚠️
...s/LeadBundle/Controller/BatchSegmentController.php 0.00% 1 Missing ⚠️
...p/bundles/LeadBundle/Controller/ListController.php 66.66% 1 Missing ⚠️
...Bundle/Controller/MobileNotificationController.php 0.00% 1 Missing ⚠️
...cationBundle/Controller/NotificationController.php 0.00% 1 Missing ⚠️
app/bundles/SmsBundle/Controller/SmsController.php 0.00% 1 Missing ⚠️
...s/MauticFocusBundle/Controller/FocusController.php 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                6.x   #14384   +/-   ##
=========================================
  Coverage     63.41%   63.41%           
  Complexity    34688    34688           
=========================================
  Files          2280     2280           
  Lines        103766   103766           
=========================================
  Hits          65801    65801           
  Misses        37965    37965
Files with missing lines Coverage Δ
.../ApiBundle/Controller/FetchCommonApiController.php 79.72% <100.00%> (ø)
...idator/Constraints/CircularDependencyValidator.php 100.00% <100.00%> (ø)
...DashboardBundle/Controller/DashboardController.php 32.05% <100.00%> (ø)
...tentBundle/Controller/DynamicContentController.php 52.99% <100.00%> (ø)
...bundles/EmailBundle/Controller/EmailController.php 64.21% <100.00%> (ø)
...es/LeadBundle/Controller/Api/LeadApiController.php 45.55% <100.00%> (ø)
...p/bundles/PageBundle/Controller/PageController.php 36.40% <100.00%> (ø)
...ndles/ReportBundle/Controller/ReportController.php 59.14% <100.00%> (ø)
app/bundles/DashboardBundle/Dashboard/Widget.php 61.90% <0.00%> (ø)
...p/bundles/FormBundle/Controller/FormController.php 45.14% <0.00%> (ø)
... and 8 more

@escopecz escopecz added this to the 6.0 milestone Dec 17, 2024
@escopecz escopecz added user-testing-passed PRs which have been successfully tested by the required number of people. and removed ready-to-test PR's that are ready to test labels Dec 17, 2024
@matbcvo
Copy link
Contributor

matbcvo commented Dec 17, 2024

The code changes look good to me.

@escopecz escopecz merged commit 01cc219 into mautic:6.x Dec 18, 2024
17 checks passed
@escopecz escopecz added code-review-passed PRs which have passed code review and removed code-review-needed PR's that require a code review before merging user-testing-passed PRs which have been successfully tested by the required number of people. labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbcvo matbcvo matbcvo approved these changes

+1 more reviewer

@laurielim laurielim laurielim approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review focus-items Anything related to focus items
Projects
Open Source Fridays
Archived in project
Milestone
6.0.0-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@escopecz @matbcvo @laurielim