Skip to content

[UX] Dynamic content slot generator #14372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 56 commits into from
Jan 15, 2025
Merged

[UX] Dynamic content slot generator #14372

merged 56 commits into from
Jan 15, 2025

Conversation

andersonjeccel
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) 🟢
New feature/enhancement? (use the a.x branch) 🟢
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🔴
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

Did you already feel a desire to give up on using dynamic content because the feature doesn't help you to make it usable?

this PR fixes the need of reading the docs and crafting manually, by hand, your dynamic content slot for inserting into a website.

Also:

  • fixes alerts positioned by absolute instead of fixed (you weren't able to see it if scrolling down the page before)
  • migrated some classes to alternatives to ensure UI is defining them to the right elements
  • fixed a bug on the buttons line height for sizes bigger than lg (they were misaligned)
  • text-muted class became text-secondary, and I hope other devs keep it consistent (fallback still there for compatibility)
Before After
image image

image

image

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open Dynamic Content
  3. Create new
  4. Set Is campaign based? to No
  5. Define a name for the slot
  6. Save & close
  7. On its details, check the generator
  8. Write anything as default content and click to copy
  9. See that you receive a success message
  10. Try changing wrapper or using the HTML mode, click copy and paste somewhere to see it

@andersonjeccel andersonjeccel requested review from a team, mchojrin and laurielim December 15, 2024 22:07
@andersonjeccel andersonjeccel self-assigned this Dec 15, 2024
@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging user-experience Anything related to related to workflows, feedback, and navigation dynamic-content labels Dec 15, 2024
@andersonjeccel andersonjeccel added this to the 5.2.1 milestone Dec 15, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.68%. Comparing base (39b4b77) to head (3bd2fa9).
Report is 57 commits behind head on 6.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                6.x   #14372   +/-   ##
=========================================
  Coverage     63.68%   63.68%           
  Complexity    34630    34630           
=========================================
  Files          2277     2277           
  Lines        103598   103598           
=========================================
  Hits          65976    65976           
  Misses        37622    37622
Files with missing lines Coverage Δ
app/bundles/EmailBundle/Form/Type/EmailType.php 97.74% <100.00%> (ø)
...ndles/LeadBundle/Form/Type/ContactChannelsType.php 92.30% <ø> (ø)
...es/PageBundle/Form/Type/ConfigTrackingPageType.php 100.00% <ø> (ø)
app/bundles/PageBundle/Form/Type/PageType.php 92.10% <ø> (ø)

@andersonjeccel andersonjeccel force-pushed the dynamic-content-slot-generator branch from 70d6746 to 228a05a Compare December 16, 2024 20:10
@RCheesley RCheesley modified the milestones: 5.2.1, 6.0 Dec 17, 2024
@RCheesley
Copy link
Member

As this is an enhancement to a feature, it will need to be staged for the 6.0 release and rebased accordingly @andersonjeccel please! Thank you!

@RCheesley RCheesley added enhancement Any improvement to an existing feature or functionality and removed bug Issues or PR's relating to bugs labels Dec 17, 2024
jos0405
jos0405 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@jos0405 jos0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, the addition of "Choose how to integrate your dynamic content" is displayed perfectly!

image

I approve it, but switching from campaign based and non campaign based didn't work when I first switched - maybe unrelated.

image

@jos0405 jos0405 added user-testing-passed PRs which have been successfully tested by the required number of people. and removed pending-test-confirmation PR's that require one test before they can be merged labels Jan 7, 2025
@andersonjeccel
Copy link
Contributor Author

@jos0405 Thank you for flagging the issue and testing!

@andersonjeccel andersonjeccel force-pushed the dynamic-content-slot-generator branch from da73bb2 to 8309e4f Compare January 7, 2025 19:38
@abhisekmazumdar
Copy link
Member

I'm not sure why this is still breaking. I'm seeking input from the community here.

@andersonjeccel andersonjeccel removed the has-conflicts Pull requests that cannot be merged until conflicts have been resolved label Jan 9, 2025
kuzmany
kuzmany approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically works

@matbcvo matbcvo added the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Jan 14, 2025
@escopecz escopecz merged commit 2d8c86b into mautic:6.x Jan 15, 2025
27 checks passed
@andersonjeccel andersonjeccel deleted the dynamic-content-slot-generator branch January 15, 2025 10:18
@matbcvo matbcvo mentioned this pull request Jan 16, 2025
Merged
@mautibot
Copy link
Contributor

This pull request has been mentioned on Mautic Forums. There might be relevant details there:

https://forum.mautic.org/t/mautic-6-is-here-alpha-release-is-ready-for-you-to-start-testing/34874/1

@mautibot
Copy link
Contributor

This pull request has been mentioned on Mautic Forums. There might be relevant details there:

https://forum.mautic.org/t/mautic-6-is-here-alpha-release-is-ready-for-you-to-start-testing/34900/1

@mautibot
Copy link
Contributor

This pull request has been mentioned on Mautic Forums. There might be relevant details there:

https://forum.mautic.org/t/mautic-6-0-orion-edition-is-released/35360/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuzmany kuzmany kuzmany approved these changes

@jos0405 jos0405 jos0405 approved these changes

@mchojrin mchojrin Awaiting requested review from mchojrin mchojrin was automatically assigned from mautic/ux-ui-tiger-team

@laurielim laurielim Awaiting requested review from laurielim laurielim was automatically assigned from mautic/ux-ui-tiger-team

@RCheesley RCheesley Awaiting requested review from RCheesley

@escopecz escopecz Awaiting requested review from escopecz

+2 more reviewers

@shinde-rahul shinde-rahul shinde-rahul approved these changes

@oltmanns-leuchtfeuer oltmanns-leuchtfeuer oltmanns-leuchtfeuer approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@andersonjeccel andersonjeccel

Labels
code-review-passed PRs which have passed code review dynamic-content enhancement Any improvement to an existing feature or functionality ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged T1 Low difficulty to fix (issue) or test (PR) user-experience Anything related to related to workflows, feedback, and navigation user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Open Source Fridays
Archived in project
UX/UI Tiger Team
Status: Done
Milestone
6.0.0-alpha
Development

Successfully merging this pull request may close these issues.