Removing the Gated Video feature #14284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAUT-11747 - Removing Gated Video
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 6.x #14284 +/- ##
============================================
- Coverage 63.23% 63.22% -0.02%
+ Complexity 34561 34555 -6
============================================
Files 2269 2268 -1
Lines 103351 103315 -36
============================================
- Hits 65351 65316 -35
+ Misses 38000 37999 -1
|
matbcvo
approved these changes
Dec 3, 2024
|
This pull request has been mentioned on Mautic Forums. There might be relevant details there: https://forum.mautic.org/t/mautic-6-is-here-alpha-release-is-ready-for-you-to-start-testing/34874/1 |
|
This pull request has been mentioned on Mautic Forums. There might be relevant details there: https://forum.mautic.org/t/mautic-6-is-here-alpha-release-is-ready-for-you-to-start-testing/34900/1 |
|
This pull request has been mentioned on Mautic Forums. There might be relevant details there: https://forum.mautic.org/t/mautic-6-0-orion-edition-is-released/35360/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The Froogaloop2 library used to be used in the Gated Video feature. An old Mautic video about this feature is here:
https://www.youtube.com/watch?v=Er-MFj3s1CU
This is no longer implemented in the GrapesJS builder and the legacy builder will be removed in M6 as well so it cannot be configured.
The Froogaloop library is EOL for 13 years. I’m not sure which Froogaloop2 library was used in #11467 when CDN has stopped working, but the first repository I found is also archived for 2 years.
Steps to test this PR:
There are no testing steps as this PR is removing an unused feature that cannot be configured.
Other areas of Mautic that may be affected by the change:
List deprecations along with the new alternative:
List of areas covered by the unit and/or functional tests: