Skip to content

Conversation

andersonjeccel
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🔴
Deprecations? 🟢
BC breaks? (use the c.x branch) 🟢
Automated tests included? 🔴
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR removes all interface styles related to Froala.


@andersonjeccel andersonjeccel self-assigned this Nov 14, 2024
@andersonjeccel andersonjeccel added user-interface Anything related to appearance, layout, and interactivity code-review-needed PR's that require a code review before merging bc-break A BC break PR for major release milestones only labels Nov 14, 2024
@andersonjeccel andersonjeccel added this to the 6.0 milestone Nov 14, 2024
@andersonjeccel
Copy link
Contributor Author

@escopecz Going there and start deleting things is a therapy, but doing it in PHP and JS might break things that we want working

so I compiled changes in LESS/CSS and left the other parts for you :)

Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will need some PHP and JS to be deleted too as you mentioned, but this is a good start 👍

@escopecz
Copy link
Member

escopecz commented Dec 3, 2024

@andersonjeccel there are some conflicts

@escopecz escopecz added the has-conflicts Pull requests that cannot be merged until conflicts have been resolved label Dec 3, 2024
@andersonjeccel andersonjeccel removed the has-conflicts Pull requests that cannot be merged until conflicts have been resolved label Dec 5, 2024
@andersonjeccel
Copy link
Contributor Author

@escopecz solved

@escopecz escopecz merged commit 426e96a into mautic:6.x Dec 5, 2024
17 checks passed
@andersonjeccel andersonjeccel deleted the bc-remove-froala-styles branch December 5, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bc-break A BC break PR for major release milestones only code-review-needed PR's that require a code review before merging user-interface Anything related to appearance, layout, and interactivity
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants