Skip to content

[UI] Marketplace details header and layout #14199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Feb 24, 2025
Merged

[UI] Marketplace details header and layout #14199

merged 32 commits into from
Feb 24, 2025

Conversation

andersonjeccel
Copy link
Contributor

@andersonjeccel andersonjeccel commented Oct 14, 2024 •
edited
Loading

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🟢
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🔴
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR brings life to plugin details.

  • Adds a bigger header
  • The header changes its color dynamically based on the plugin name
  • All generated colors have enough contrast against the text on top
  • It adapts its lightness depending on your theme (light or dark)
  • Features a handcrafted background, using icons related to marketing

My original idea was to bring more items to this header (like icons/plugin logo) but this would require each package having their own icon (we're probably far from this, so left out for now)

Before After
image image

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open the admin menu
  3. Open Marketplace
  4. Open any plugins

@andersonjeccel andersonjeccel reopened this Jan 9, 2025
@andersonjeccel andersonjeccel force-pushed the ui-marketplace-details-w-header branch from 8460d5a to ec6177f Compare January 9, 2025 20:29
@andersonjeccel andersonjeccel changed the base branch from 5.x to 6.x January 10, 2025 10:15
@andersonjeccel andersonjeccel requested review from a team, LordRembo and mchojrin January 10, 2025 10:16
@andersonjeccel andersonjeccel self-assigned this Jan 10, 2025
@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging enhancement Any improvement to an existing feature or functionality marketplace anything related to the marketplace labels Jan 10, 2025
@andersonjeccel andersonjeccel added this to the 6.0 milestone Jan 10, 2025
@andersonjeccel andersonjeccel marked this pull request as draft January 13, 2025 12:26
@andersonjeccel andersonjeccel changed the title [UI] Marketplace details header [UI] Marketplace details header and layout Jan 13, 2025
shinde-rahul
shinde-rahul reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@shinde-rahul shinde-rahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a conflict; please resolve it.

@RCheesley RCheesley modified the milestones: 6.0.0-alpha, 6.0.0-beta Jan 27, 2025
RCheesley
RCheesley requested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these changes, I just wondered why we've got a duplicated button, perhaps one isn't needed?

Mautic-02-18-2025_05_00_PM (1)
Mautic-02-18-2025_05_00_PM

Other than that, all working as expected! 🚀

@RCheesley RCheesley added the pending-feedback PR's and issues that are awaiting feedback from the author label Feb 18, 2025
@RCheesley
Copy link
Member

@andersonjeccel can you address this feedback?

@andersonjeccel andersonjeccel removed the pending-feedback PR's and issues that are awaiting feedback from the author label Feb 21, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.24%. Comparing base (8b08484) to head (75396e8).
Report is 1 commits behind head on 6.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                6.x   #14199   +/-   ##
=========================================
  Coverage     64.24%   64.24%           
  Complexity    34576    34576           
=========================================
  Files          2268     2268           
  Lines        103294   103294           
=========================================
  Hits          66366    66366           
  Misses        36928    36928

RCheesley
RCheesley approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the duplicated button! GTG! 🚀

@RCheesley RCheesley added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Feb 21, 2025
matbcvo
matbcvo approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@matbcvo matbcvo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me. I have tested the PR, and it works as expected.

@matbcvo matbcvo added code-review-passed PRs which have passed code review user-testing-passed PRs which have been successfully tested by the required number of people. ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed code-review-needed PR's that require a code review before merging pending-test-confirmation PR's that require one test before they can be merged labels Feb 21, 2025
@RCheesley RCheesley merged commit 02080c2 into mautic:6.x Feb 24, 2025
17 checks passed
@andersonjeccel andersonjeccel deleted the ui-marketplace-details-w-header branch February 24, 2025 14:10
@RCheesley RCheesley modified the milestones: 6.0.0-beta, 6.0.0-beta2 Mar 5, 2025
@mautibot
Copy link
Contributor

mautibot commented Mar 6, 2025

This pull request has been mentioned on Mautic Forums. There might be relevant details there:

https://forum.mautic.org/t/announcing-mautic-6-beta-now-available-for-testing/35196/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbcvo matbcvo matbcvo approved these changes

@RCheesley RCheesley RCheesley approved these changes

+1 more reviewer

@shinde-rahul shinde-rahul shinde-rahul left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@andersonjeccel andersonjeccel

Labels
code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality marketplace anything related to the marketplace ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Open Source Fridays
Status: 🥳 Done
UX/UI Tiger Team
Status: Done
Milestone
6.0.0-beta2
Development

Successfully merging this pull request may close these issues.
5 participants
@andersonjeccel @RCheesley @mautibot @matbcvo @shinde-rahul