Skip to content

Datetime type fields | Anniversary value doesn't work on segment rebuilds #14010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Datetime type fields | Anniversary value doesn't work on segment rebuilds #14010

wants to merge 1 commit into from

Conversation

dadarya0
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) 🟢
New feature/enhancement? (use the a.x branch) 🔴
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🟢
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

DateTime type fields | Anniversary value doesn't work on segment rebuilds.

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Create a datetime type custom field
  3. create a segment based on above filed
  4. Use Anniversary as value for this and use “equal” operator.
  5. Segment rebuild should work fine

@dadarya0 dadarya0 added the segments Anything related to segments label Jul 26, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.47%. Comparing base (e9bdf9d) to head (8fb2b30).
Report is 1 commits behind head on 5.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #14010      +/-   ##
============================================
- Coverage     62.47%   62.47%   -0.01%     
  Complexity    34321    34321              
============================================
  Files          2257     2257              
  Lines        102626   102626              
============================================
- Hits          64116    64115       -1     
- Misses        38510    38511       +1
Files Coverage Δ
...e/Segment/Decorator/Date/Other/DateAnniversary.php 54.54% <100.00%> (ø)

... and 1 file with indirect coverage changes

@PatrickJenkner PatrickJenkner added code-review-needed PR's that require a code review before merging user-testing-passed PRs which have been successfully tested by the required number of people. labels Jul 26, 2024
@kuzmany
Copy link
Member

kuzmany commented Jul 26, 2024

Duplicate of #13871

@kuzmany kuzmany marked this as a duplicate of #13871 Jul 26, 2024
@escopecz escopecz added duplicate and removed code-review-needed PR's that require a code review before merging segments Anything related to segments user-testing-passed PRs which have been successfully tested by the required number of people. labels Jul 26, 2024
@escopecz escopecz mentioned this pull request Jul 26, 2024
Merged
@escopecz
Copy link
Member

@kuzmany thanks for pointing that out!

I merged #13871 and closing this as a duplicate.

@escopecz escopecz closed this Jul 26, 2024
@escopecz escopecz deleted the anniversary-support-to-date-time-field branch October 2, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@shinde-rahul shinde-rahul shinde-rahul approved these changes

@nileshlohar nileshlohar nileshlohar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dadarya0 @kuzmany @escopecz @shinde-rahul @nileshlohar @PatrickJenkner