Automatic code cleanup (Rector) #14094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca21044 to
6d7b478
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 6.x #14094 +/- ##
============================================
- Coverage 63.28% 63.28% -0.01%
+ Complexity 34611 34610 -1
============================================
Files 2271 2271
Lines 103547 103539 -8
============================================
- Hits 65527 65520 -7
+ Misses 38020 38019 -1
|
matbcvo
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on #13962 I wanted to run Rector with rules for Symfony 6. We still have a config for that where I could just increase the Symfony version. However, the command
bin/rector --config=rector-older-symfony.phpreturned a lot of changes also for Symfony 5.4. This PR is adding those changes now so the Symfony 6 PR would get smaller
and the current Mautic 5 code neater(too late, M5 is in the bug fix release only).📋 Steps to test this PR:
Most of the changes were done in the test files. I've added all the changes to the production files into this commit. From those changes we can for example test:
bin/console mautic:fields:analysejust to test one.