Skip to content

TASK: Removes deprecated GenericPointSettingsType for M6 #13904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2024
Merged

TASK: Removes deprecated GenericPointSettingsType for M6 #13904

merged 2 commits into from
Nov 5, 2024

Conversation

putzwasser
Copy link
Contributor

@putzwasser putzwasser commented Jun 28, 2024 •
edited
Loading

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🔴
Deprecations? 🟢
BC breaks? (use the c.x branch) 🟢
Automated tests included? 🟢
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR removes the GenericPointSettingsType for M6. Adding this PR so this is not forgotten. Please add the 6.0 release tag.

Refer to #13868

@andersonjeccel andersonjeccel added this to the 6.0 milestone Aug 20, 2024
@andersonjeccel andersonjeccel added deprecation Includes deprecations blocked Something blocks this PR/issue (e.g. waiting for another PR to be merged) bc-break A BC break PR for major release milestones only points-scoring Anything related to points labels Aug 20, 2024
@RCheesley
Copy link
Member

What is this PR blocked by?

@putzwasser
Copy link
Contributor Author

Blocked by #13868

This needs to get merged first. Don't know why #13868 is stuck, actually.

@escopecz escopecz changed the base branch from 5.x to 6.x November 5, 2024 09:40
@escopecz escopecz self-requested a review November 5, 2024 09:59
@escopecz escopecz removed the blocked Something blocks this PR/issue (e.g. waiting for another PR to be merged) label Nov 5, 2024
escopecz
escopecz approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 👍

@escopecz escopecz force-pushed the 6.0-remove-deprecated-form-type branch from 3f9411a to cdbdd15 Compare November 5, 2024 10:05
@escopecz escopecz added refactoring The change does not change behavior but improves the code ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged labels Nov 5, 2024
@escopecz escopecz merged commit a479974 into mautic:6.x Nov 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
bc-break A BC break PR for major release milestones only deprecation Includes deprecations points-scoring Anything related to points ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged refactoring The change does not change behavior but improves the code
Projects
None yet
Milestone
6.0.0-alpha
Development

Successfully merging this pull request may close these issues.
4 participants
@putzwasser @RCheesley @escopecz @andersonjeccel