TASK: Removes deprecated CoreParametersHelper::getParameter
#13837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 6.x #13837 +/- ##
=========================================
Coverage 64.54% 64.54%
+ Complexity 34614 34613 -1
=========================================
Files 2271 2271
Lines 103442 103440 -2
=========================================
+ Hits 66765 66766 +1
+ Misses 36677 36674 -3
|
escopecz
reviewed
Jun 18, 2024
|
@putzwasser could you please rebase this to the 6.x branch so we can get it ready for release? Many thanks! |
kuzmany
previously approved these changes
Feb 18, 2025
|
Bumping this from the milestone as it's not yet rebased to 6.x - let's aim to get it into the Release Candidate. |
This PR removes the deprecated function `CoreParametersHelper::getParameter` which was meant to be removed in M4, already. Since it is deprecated since M3 this is hardly a breaking change as its removal was expected to happen with the M4 release.
f8d0ec2 to
3cf6230
Compare
escopecz
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the deprecated function
CoreParametersHelper::getParameterwhich was meant to be removed in M4, already.Since it is deprecated since M3 I think this can be merged into 5.x as its removal was expected to happen with the M4 release.
📋 Steps to test this PR: