Description

Before this PR fixes two related bugs in the custom Point Action extension logic.

1. A simple Point Action can omit providing a form to set additional properties (e.g., limiting points for downloads only to specific assets). If it does that a redundant form element (Change points (+/-) input element) gets shown.
2. Mautic lets you set the points change using the Change points (+/-) input element at the top. This field is ignored by the default attribution logic. It uses the second and redundant input element.

What 2 means: If you provide your own action property form, you can't set a point change value that Mautic will use. Your action gets triggered but no points change is applied.

Side-note: Why do the built-in point actions work, then? ⇒ Because they also provide their own callback in their config (I won't go into detail here, but this obfuscated this bug, as their actions and trigger/attribution conditions are more complex).

The form

Before this PR Mautic added the GenericPointSettingsType to the Point Action form, if the custom action doesn't provide its own property form type. This form type renders the Change points (+/-) input element a second time.

Before	After

Point attribution

Before this PR the Mautic\PointBundle\Helper\EventHelper::engagePointAction tried to find the point change value in the custom action's attributes.

This made it necessary to use the second (and redundant; marked red above) points delta input element. If you provided your own property form type Mautic always applied a point change value of 0.

So, basically: Mautic ignored what you've entered in the top the Change points (+/-) input element.

📋 Steps to test this PR:

1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
2. Add the TestPointSubscriber to your Mautic instance (put it in any EventListener folder)
3. Navigate to Point Actions > New
4. Select the Hello World - My custom action action in the Action taken by contact form element
5. See that no additional Change points (+/-) input element gets added
6. Add points, save
7. Open an incognito tab
8. Create a new identified Contact by submitting some form
9. See that the newly identified Contact got attributed the points you defined

Sample Listener

This listener registers an example custom point action and an event listener to the LeadEvents::LEAD_IDENTIFIED event that triggers the point action.

<?php

declare(strict_types=1);

use Mautic\LeadBundle\Event\LeadEvent;
use Mautic\LeadBundle\LeadEvents;
use Mautic\PointBundle\Event\PointBuilderEvent;
use Mautic\PointBundle\Model\PointModel;
use Mautic\PointBundle\PointEvents;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;

class TestPointSubscriber implements EventSubscriberInterface
{
	public const ACTION_NAME = 'helloworld.action.custom_action';

	public function __construct(
		private PointModel $pointModel,
	) {
	}

	public static function getSubscribedEvents(): array
	{
		return [
			PointEvents::POINT_ON_BUILD => ['onPointBuild', 0],
			LeadEvents::LEAD_IDENTIFIED => ['onLeadIdentified', 0],
		];
	}

	/**
	 * Register the plugin's custom Point Action.
	 */
	public function onPointBuild(PointBuilderEvent $event): void
	{
		$action = [
			'group' => 'Hello World',
			'label' => 'My custom action',
		];

		$event->addAction(self::ACTION_NAME, $action);
	}

	/**
	 * Sample event listener just to trigger the point action above
	 */
	public function onLeadIdentified(LeadEvent $event): void
	{
		$this->pointModel->triggerAction(self::ACTION_NAME);
	}
}