-
-
Notifications
You must be signed in to change notification settings - Fork 3k
[UI/UX] Campaign builder events #13771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI/UX] Campaign builder events #13771
Conversation
revert Revert "fixing broken darken/lighten" This reverts commit bcf4ac98e07c0c17162a74794a8161d5398c3d7c.
This reverts commit a8c4748.
fe27b74
to
5bdd592
Compare
@andersonjeccel Im all for the modernization of the campaign builder, but I gotta say that the new color-scene of "Decision" and "Action" look too indifferent in my option: Going from "Green", "Blue", "Red/Orange" colorscheme to "Blue", "darker blue", "yellow" lowers the visual clarity by a significant amount. |
@oltmanns-leuchtfeuer What you say totally makes sense and I agree about it Could you create a design proposal for this panel? Then I can implement it |
Hi @andersonjeccel, I have made up my mind regarding the campaign builder and worked on a different color scheme: It sticks closer to the old one, but with slightly different colors to make them feel more connected while being clearly visibly distinguishable. Color codes are these ones, all taken from the Mautic.org frontpage:
In my opinion, this already gives a lot more "first look clarity": My bigger concern currently is the size each box per Action/Decision/Condition. They went up in size by a big margin and differ in size. While, for smaller campaigns this is rather positiv, bigger and more complex campaigns get overwhelming instantly. For Example this campaign, made in the old builder would get unfathomably difficult to glance at in the new builder: I got different approaches in mind to solve this:
Please feel free to comment and constructively criticise my takes. :) |
@LordRembo In terms of technical implementation for the proposed color scheme in the previous comment, I would have to extend the tokens system to address a third brand color (which adds a new layer of complexity both for the tokens and for branding later) Do you think it’s worth it? I’m thinking about reverting the color changes made to the panel so they go back to green and red, just to finish this PR for now and merge Because the yellow background color will keep being inaccessible, low contrast even for people without disabilities ; solving this issue requires a greater panel redesign |
@andersonjeccel If it would be easier to get alignment & clear technical hurdles, I think it's a good idea to split the color changes into a different PR and keep the rest of the changes in this PR. Consider this for the color changes:
As for accessibility considerations: the yellow could work if the text was made dark instead of white. Or you'd have to make the background-color brown ( |
I''l fix things using another PR to improve readability and more careful planning to avoid just throwing something in the interface, ok? Regarding size, to me it feels that bigger and complex campaigns are already overwhelming by their existance; this new redesign introduced visible information for users to understand a campaign like yours without entering in each of the 35809 thousands steps manually For example, I have no idea of what "Change multiselect" is about in your campaign. Are you changing the value of a custom field? Are you changing which form appears to a lead? Something completely unrelated to both? It gets even more difficult when talking about clients that just make campaigns like there was no tomorrow without labeling steps... Now to answer your last ideas:
Okay then, let's document some thoughts
|
@oltmanns-leuchtfeuer Oh, enter in the Slack channel #tt-ux_ui to see more things |
This reverts commit c5782e6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kuzmany I'll tackle this in another PR, thanks for reporting! |
Description
This PR is based on another PR, where I introduce tokens to replace most of the UI variables, aiming to improve consistency in all components. We need it to be merged before this one becomes available for code review.
Other dependencies:
It enhances UX and UI for the builder.
Specifically:
📋 Steps to test this PR: