Skip to content

Conversation

dadarya0
Copy link
Contributor

@dadarya0 dadarya0 commented Feb 14, 2024

Q A
Bug fix? (use the a.b branch) No
New feature/enhancement? (use the a.x branch) Yes
Deprecations? [ ]
BC breaks? (use the c.x branch) No
Automated tests included? Yes
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

This PR introduces a new report data source, Audit Log.
This will enable users to see and analyse audit log in a report format.
The audit log details are shown in prettified JSON format where 0 represents old and 1 represents new values.
This report allows only for admin user

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Create new report
  3. Select Audit logs as Data source
  4. Select columns and save report

@dadarya0 dadarya0 added the WIP PR's that are not ready for review and are currently in progress label Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (aa02bde) 59.77% compared to head (cc00277) 59.77%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                5.x   #13373   +/-   ##
=========================================
  Coverage     59.77%   59.77%           
- Complexity    33586    33606   +20     
=========================================
  Files          2216     2217    +1     
  Lines        100432   100490   +58     
=========================================
+ Hits          60029    60064   +35     
- Misses        40403    40426   +23     
Files Coverage Δ
...bundles/CoreBundle/Controller/CommonController.php 82.14% <100.00%> (ø)
...ndles/ReportBundle/Controller/ReportController.php 45.21% <50.00%> (+0.02%) ⬆️
...undles/CoreBundle/Twig/Extension/HtmlExtension.php 82.60% <33.33%> (-7.40%) ⬇️
...auticFocusBundle/EventListener/FocusSubscriber.php 73.21% <71.42%> (-0.26%) ⬇️
...dles/CoreBundle/EventListener/ReportSubscriber.php 60.86% <60.86%> (ø)

@dadarya0 dadarya0 requested review from a team and aarohiprasad and removed request for a team February 14, 2024 17:33
@dadarya0 dadarya0 self-assigned this Feb 14, 2024
@dadarya0 dadarya0 added reports Anything related to reports unforking Used for PRs in the Acquia's unforking initiative and removed WIP PR's that are not ready for review and are currently in progress labels Feb 14, 2024
aarohiprasad
aarohiprasad previously approved these changes Feb 15, 2024
Copy link
Contributor

@aarohiprasad aarohiprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @dadarya0

aarohiprasad
aarohiprasad previously approved these changes Feb 15, 2024
kuzmany
kuzmany previously approved these changes Feb 16, 2024
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works as expected 👍

@dadarya0 dadarya0 dismissed stale reviews from kuzmany and aarohiprasad via cc00277 February 16, 2024 07:38
@dadarya0
Copy link
Contributor Author

@aarohiprasad @kuzmany could you please review again cc00277 as sorting, searching, pagination everything was broken in 5.x and I have fixed same in this PR too.

@dongilbert dongilbert merged commit 6682fe5 into mautic:5.x Feb 16, 2024
@escopecz escopecz added this to the 5.1.0 milestone Feb 19, 2024
@escopecz escopecz added the feature A new feature for inclusion in minor or major releases label Feb 19, 2024
@RCheesley
Copy link
Member

@dadarya0 no docs PR was made for this PR. If you have chance can you please add one to add the necessary: https://docs.mautic.org/en/5.x/reports/reports.html#data-sources

cc @mautic/education-team as this is required for the 5.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature for inclusion in minor or major releases reports Anything related to reports unforking Used for PRs in the Acquia's unforking initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants