Skip to content

Fix gated video with froogaloop library #11467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2022
Merged

Fix gated video with froogaloop library #11467

merged 2 commits into from
Sep 19, 2022

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Sep 13, 2022

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Gated video stop working because mandatory froogaloop2 stop working from CDN https://f.vimeocdn.com/js/froogaloop2.min.js
This PR add it to local assets directory

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Create landing page with gated video
  3. See after PR gated video working again

@kuzmany kuzmany added the bug Issues or PR's relating to bugs label Sep 13, 2022
@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022 •
edited
Loading

Codecov Report

Merging #11467 (e5f83fe) into 4.4 (203ea03) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.4   #11467      +/-   ##
============================================
+ Coverage     49.33%   49.36%   +0.03%     
- Complexity    35395    35401       +6     
============================================
  Files          2144     2144              
  Lines        105524   105534      +10     
============================================
+ Hits          52056    52101      +45     
+ Misses        53468    53433      -35
Impacted Files Coverage Δ
...les/PageBundle/EventListener/BuildJsSubscriber.php 13.33% <0.00%> (-0.63%) ⬇️
app/bundles/CoreBundle/Loader/RouteLoader.php 84.61% <0.00%> (-0.39%) ⬇️
...IntegrationsBundle/Controller/ConfigController.php 0.00% <0.00%> (ø)
...dle/Form/Type/FormSubmitActionDownloadFileType.php 0.00% <0.00%> (ø)
...undles/FormBundle/EventListener/FormSubscriber.php 66.29% <0.00%> (+24.18%) ⬆️

escopecz
escopecz approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes make sense. Thanks Zdeno!

@escopecz escopecz added pending-test-confirmation PR's that require one test before they can be merged landing-pages Anything related to landing pages labels Sep 16, 2022
@escopecz escopecz added this to the 4.4.3 milestone Sep 16, 2022
volha-pivavarchyk
volha-pivavarchyk approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@volha-pivavarchyk volha-pivavarchyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described

@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Sep 19, 2022
@escopecz escopecz merged commit 6e81e89 into 4.4 Sep 19, 2022
@escopecz escopecz deleted the fix-gated-video-froogaloop branch August 10, 2023 10:09
@escopecz escopecz mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

+1 more reviewer

@volha-pivavarchyk volha-pivavarchyk volha-pivavarchyk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement landing-pages Anything related to landing pages ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Milestone
4.4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@kuzmany @escopecz @volha-pivavarchyk