Skip to content

Add Vim Terminal API argument options (-t, -T {prefix}) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 28, 2019

Conversation

tyru
Copy link
Contributor

@tyru tyru commented Dec 27, 2019

This PR adds below argument options.

  • -t
  • -T {prefix}

This allows Vim to open selected file directly from Vim's terminal window.

I wrote about usage to README.

@tyru tyru force-pushed the add-terminal-api-options branch from 584653a to 9ea29b0 Compare December 27, 2019 16:29
@tyru
Copy link
Contributor Author

tyru commented Dec 27, 2019

Added sample :Gof command to README ✨

@tyru
Copy link
Contributor Author

tyru commented Dec 27, 2019

Hmm, I uploaded :Gof screen capture to imgur, the image appears in the imgur site but direct link to gif does not show the image 🤔
https://imgur.com/dJ8ypKT

@tyru tyru force-pushed the add-terminal-api-options branch from 859d671 to 09f5e76 Compare December 27, 2019 16:46
@tyru
Copy link
Contributor Author

tyru commented Dec 27, 2019

I registered imgur and uploaded (I uploaded the previous images from free account (not logged-in)).
And fixed all image URLs.

@tyru
Copy link
Contributor Author

tyru commented Dec 28, 2019

@mattn How do you think? Is there plan to merge?

I think -T should need to be changed, because prefix is for call of terminal-api, but currently drop is used.

  • change -T [prefix] to -tf [funcname]
  • add -tc ["call" or "drop"]

so we can send ["call","[funcname]","[filename]"] or ["drop","[filename]"]

@tyru
Copy link
Contributor Author

tyru commented Dec 28, 2019

Or, -tc {command} is not necessary because currently Vim terminal API only supports call or drop.

  • change -T [prefix] to -tf [funcname]
  • if -tf option was given, send ["call","[funcname]","[filename]"]. otherwise ["drop","[filename]"]

Done edc392f

@mattn
Copy link
Owner

mattn commented Dec 28, 2019

LGTM, Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants