[Windows] harden system DLL loading #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically loading system DLLs from relative paths with NewLazyDLL is vulnerable to DLL preloading attacks. See the warning on NewLazyDLL here [0]. [0] https://pkg.go.dev/golang.org/x/sys/windows?GOOS=windows#NewLazyDLL
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically loading system DLLs from relative paths with NewLazyDLL is vulnerable to DLL preloading attacks. See the warning on NewLazyDLL here [0].
[0] https://pkg.go.dev/golang.org/x/sys/windows?GOOS=windows#NewLazyDLL
We had this filed as a bug against us in Gio, and it prompted me to look through my dependency trees to try to help other people catch it.