Skip to content

Conversation

shiena
Copy link

@shiena shiena commented Jun 29, 2021

fix #139

upmをサポートするように構成しました。それに伴ない以下も修正しています。

  • gitignore.ioを使って.gitignoreを更新
  • Unity2019.4.28f1へ更新
  • UniRxをopenupmから取得するように変更
  • エディタ拡張はupm用のpackage.jsonを無視する
  • MiniJSONが重複するとエラーになるのでnamespaceをUnidux.MiniJSONに変更
  • upmのsamplesセクションに対応するためにExamplesフォルダを隠しフォルダのExamples~へ移動
  • upmでインストールする方法をREADMEへ追加

image

@mattak
Copy link
Owner

mattak commented Aug 11, 2021

@shiena
Thanks for your request!
& Sorry for my late response.

I'm very happy to see the request.
But I cannot merge this request, because the pull request code is too much moditications and hard to check differences.
I'll divide the codes and create pull new requests.

And I have a couple of concerns about...

1. gitginore file

It seems gitignores file are not fit the gitginore.io services.
(https://www.toptal.com/developers/gitignore/api/unity)

There are a lots of your environmental modifications and I don't agree the settings.
I'll create the new gitignore just for fitting gitignore.io

2. Unity version

Unity version is too old because I rarely maintenance and update lazily.
I'll update to required latest unity version to 2019.4.29f1 from 2018.2.8f1

3. UPM domain and Author name

Requested UPM domain name was com.mattak.unidux.
But I don't have the domain name mattak.com.
Reverse domain naming culture is derived from java, I think the domain naming should be fit my holding network domain for avoiding conflict.

I have following domains.

  • mattak.me
  • mattak.dev

So I'll change it to fit it.
And checking package.json it seems my name was wrong.

4. UPM directory layout

I'll fit renaming structure as you mensions.
Examples -> Samples~

At last.

I'll checked your zenn articles and it was so helpful.

Thanks for your all contributions!
and I'll update upm version as soon as I can.

@mattak
Copy link
Owner

mattak commented Aug 11, 2021

@shiena
Finally I rollout new version 0.4.0 for supporting upm.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Unity Package Manager (UPM)
2 participants