Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Add some limitations to alias creation #5124

Merged
merged 1 commit into from
May 2, 2019
Merged

Add some limitations to alias creation #5124

merged 1 commit into from
May 2, 2019

Conversation

babolivier
Copy link
Contributor

No description provided.

@babolivier babolivier force-pushed the babolivier/aliases branch from 2d9fe9b to 917c029 Compare May 2, 2019 08:29
@babolivier babolivier requested a review from a team May 2, 2019 08:30
@babolivier babolivier force-pushed the babolivier/aliases branch 3 times, most recently from b3712c7 to 09986b6 Compare May 2, 2019 08:43
@codecov
Copy link

codecov bot commented May 2, 2019 •
edited
Loading

Codecov Report

Merging #5124 into develop will decrease coverage by 0.06%.
The diff coverage is 60%.

@@             Coverage Diff             @@
##           develop    #5124      +/-   ##
===========================================
- Coverage    61.72%   61.65%   -0.07%     
===========================================
  Files          335      334       -1     
  Lines        34502    34533      +31     
  Branches      5669     5684      +15     
===========================================
- Hits         21295    21290       -5     
- Misses       11678    11711      +33     
- Partials      1529     1532       +3

@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #5124 into develop will decrease coverage by 38.26%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##           develop    #5124       +/-   ##
============================================
- Coverage    61.65%   23.38%   -38.27%     
============================================
  Files          334      303       -31     
  Lines        34523    32916     -1607     
  Branches      5681     5134      -547     
============================================
- Hits         21284     7698    -13586     
- Misses       11709    25157    +13448     
+ Partials      1530       61     -1469

@babolivier babolivier force-pushed the babolivier/aliases branch from 09986b6 to 70034c9 Compare May 2, 2019 08:43
richvdh
richvdh previously requested changes May 2, 2019
View reviewed changes
@babolivier babolivier force-pushed the babolivier/aliases branch from 70034c9 to d965813 Compare May 2, 2019 08:47
@babolivier babolivier requested a review from a team May 2, 2019 08:48
@babolivier babolivier force-pushed the babolivier/aliases branch 3 times, most recently from f808515 to 4a95dc2 Compare May 2, 2019 09:19
@babolivier babolivier mentioned this pull request May 2, 2019
Merged
@babolivier babolivier force-pushed the babolivier/aliases branch from 4a95dc2 to 7b3cbf6 Compare May 2, 2019 09:35
@babolivier babolivier force-pushed the babolivier/aliases branch from 7b3cbf6 to 84196cb Compare May 2, 2019 10:05
richvdh
richvdh approved these changes May 2, 2019
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, assuming CI passes

@babolivier babolivier merged commit c193b39 into develop May 2, 2019
@babolivier babolivier mentioned this pull request May 2, 2019
Merged
babolivier added a commit that referenced this pull request May 8, 2019
@babolivier
Do checks on aliases for incoming m.room.aliases events (#5128)
1473058 
Follow-up to #5124

Also added a bunch of checks to make sure everything (both the stuff added on #5124 and this PR) works as intended.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@richvdh richvdh richvdh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@babolivier @richvdh