This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix test_metrics.py compatibility prometheus_client 0.5 #4317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prometheus_client 0.5
has a named-tupleSample
type with more member than the old plain tuple had. This PR makes sure the unit test detects this and changes the way it reads the sample.It may be a bit much for a simple test, but it beats being stuck with
0.4
purely because a test fails.The relevant change in
prometheus_client
can be found here:prometheus/client_python@b339d21#diff-3b69664ac91a714e3e457f238848dee0R38