Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Conversation

dklimpel
Copy link
Contributor

#10969 was merged a few hours to late (after RC1 1.46.0)
It will be released in Synapse 1.47.0 and not 1.46.0
Two comments in this PR needs an update.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
  • Pull request includes a sign off
  • Code style is correct (run the linters)

Signed-off-by: Dirk Klimpel dirk@klimpel.org

@dklimpel dklimpel requested a review from a team as a code owner October 29, 2021 17:06
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you!

@clokep clokep merged commit bfd7a9b into matrix-org:develop Oct 29, 2021
@dklimpel dklimpel deleted the fix_comments_10969 branch October 29, 2021 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants