Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Improve ServerNoticeServlet to avoid duplicate requests each creating a server-notices-room #9544

Closed
#10679
Closed
Improve ServerNoticeServlet to avoid duplicate requests each creating a server-notices-room#9544
#10679
Labels
S-MinorBlocks non-critical functionality, workarounds exist.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.good first issueGood for newcomers
@dklimpel

Description

@dklimpel
dklimpel
opened on Mar 4, 2021

Improve ServerNoticeServlet

synapse/synapse/rest/admin/server_notice_servlet.py

Line 28 in 33a02f0

class SendServerNoticeServlet(RestServlet):

We chatted a bit about this in #synapse-dev:matrix.org and realize that this is highlighting a bug in the servlet!

  • The txn_id should be passed into send_notice method and then passed through into create_and_send_nonmember_event (see RoomSendEventRestServlet for the proper way to do this).

It was also pointed out that some more magic might be needed to avoid creating duplicate server-notice rooms too, but maybe we can leave that to a follow-up and just add a note about it.

Originally posted by @clokep in #9520 (comment)

Also unit tests are missing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    S-MinorBlocks non-critical functionality, workarounds exist.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.good first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions