This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Auto-join rooms rate limited #8866
Description
Description
Adding a new user to rooms defined in auto_join_rooms is incorrectly rate-limited.
Steps to reproduce
- configure
homeserver.yamlwithN>3rooms listed inauto_join_rooms - register a new user
- user is joined to first three rooms correctly, however all subsequent joins are incorrectly rate-limited:
synapse.handlers.register - 453 - ERROR - POST-119262 - Failed to join new user to '#<alias>:<domain>': LimitExceededError('429: Too Many Requests')
Version information
- Version:
{
"python_version": "3.8.6",
"server_version": "1.23.0"
}- Install method: Docker
matrixdotorg/synapse:v1.23.0
- Platform: Host is Ubuntu 20.04.1 LTS
Additional info
For this particular user, also setting their display name from our LDAP failed:
rest_auth_provider - 76 - INFO - POST-119262 - Registration based on REST data was successful for @<user>:<domain>
rest_auth_provider - 81 - INFO - POST-119262 - Handling profile data
rest_auth_provider - 92 - INFO - POST-119262 - Setting display name to '<displayname>' based on profile data
rest_auth_provider - 99 - INFO - POST-119262 - Handling 3PIDs
rest_auth_provider - 106 - INFO - POST-119262 - Looking for 3PID email:<user>@<domain> in user profile
twisted - 254 - WARNING - POST-119262 - /usr/local/lib/python3.8/site-packages/twisted/internet/defer.py:1418: builtins.RuntimeWarning: coroutine 'ProfileWorkerStore.set_profile_displayname' was never awaited
rest_auth_provider - 119 - INFO - POST-119262 - 3PID is present, skipping
twisted - 254 - WARNING - - /usr/local/lib/python3.8/site-packages/twisted/internet/defer.py:1475: builtins.RuntimeWarning: coroutine 'RegistrationWorkerStore.get_user_id_by_threepid' was never awaited
I assume this is the same issue as the above messages occur less than one second after Failed to join new user, but otherwise let me know if you would like me to open a separate report.
Related issues
I can see a few issues opened recently that seem similar: #8735, #8791 and #8736.