Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Inbound federation lag metrics should not report if no messages sent/received. #8716

@michaelkaye

Description

@michaelkaye

The metrics introduced in #8430 are not clear when no inbound federation is being received from a server:

An inspection of a graph zoomed in shows this being hard to use in action

lag

This however doesn't show up as clearly when looking at a wider scale, and it's not obvious there is an issue - it just looks like it's successfully having a very small amount of lag and the problem has gone away.

lag2

Not emitting a metric while there aren't enough messages to provide any data seems like a better option here - at the moment we are emitting the out of date metric only, so any averages / minimums etc will not work correctly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    z-p2(Deprecated Label)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions