Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

For push display names are interpreted as regex #6641

@erikjohnston

Description

@erikjohnston

Specifically, if you specify a display name of [benpa] then that will cause the contains_display_name to match against the regex (^|\W)[benpa](\W|$), which matches any event with the word "a" in it.

This is because we pass the display name straight into _glob_matches and the glob to regex conversion doesn't escape regex characters in the glob. (We also probably don't want to be using display name as a glob)

Metadata

Metadata

Assignees

Labels

z-bug(Deprecated Label)z-p2(Deprecated Label)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions