Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Seven contrib files with Python syntax errors #5443

@cclauss

Description

@cclauss

flake8 testing of https://github.com/matrix-org/synapse on Python 3.7.1

$ flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics

./contrib/jitsimeetbridge/jitsimeetbridge.py:1:1: E902 IndentationError: unindent does not match any outer indentation level
#!/usr/bin/env python
^
./contrib/jitsimeetbridge/jitsimeetbridge.py:54:40: E999 SyntaxError: invalid syntax
            print "incoming from matrix",obj
                                       ^
./contrib/graph/graph.py:51:39: E999 SyntaxError: invalid syntax
            print "Run out of colours!"
                                      ^
./contrib/graph/graph3.py:29:25: E999 SyntaxError: invalid syntax
    print "Reading lines"
                        ^
./contrib/scripts/kick_users.py:16:56: E999 SyntaxError: invalid syntax
    print "Kicking members on %s in room %s matching %s" % (hs, room_id, user_id_prefix)
                                                       ^
./contrib/cmdclient/http.py:144:40: E999 SyntaxError: invalid syntax
        print "%s to %s with headers %s" % (method, url, headers_dict)
                                       ^
./contrib/cmdclient/console.py:112:22: E999 SyntaxError: invalid syntax
            print json.dumps(self.config, indent=4)
                     ^
1     E902 IndentationError: unindent does not match any outer indentation level
6     E999 SyntaxError: invalid syntax
7

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.

  • F821: undefined name name
  • F822: undefined name name in __all__
  • F823: local variable name referenced before assignment
  • E901: SyntaxError or IndentationError
  • E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree

Metadata

Metadata

Assignees

No one assigned

    Labels

    Z-Help-WantedWe know exactly how to fix this issue, and would be grateful for any contributionz-p3(Deprecated Label)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions