Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Many endpoints that serialize events don't include the transaction_id #15173

@sandhose

Description

@sandhose

According to the spec, there are many endpoints that should include the transaction_id in the unsigned section of the event. Those endpoints are:

/sync
/rooms/{roomId}/state
/rooms/{roomId}/state/{eventType}/{stateKey}
/rooms/{roomId}/context/{eventId}
/rooms/{roomId}/messages
/rooms/{roomId}/relations/{eventId}
/rooms/{roomId}/relations/{eventId}/{relType}
/rooms/{roomId}/event/{eventId}
/rooms/{roomId}/threads
/search
/rooms/{roomId}/initialSync # Deprecated
/events # Deprecated

Synapse only does that on the /sync endpoint. I have a Complement test to highlight that issue using the /rooms/{roomId}/event/{eventId} endpoint.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-Spec-Complianceplaces where synapse does not conform to the specO-FrequentAffects or can be seen by most users regularly or impacts most users' first experienceS-MinorBlocks non-critical functionality, workarounds exist.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions