This repository was archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Update MSC3912 implementation: Redaction of related events #15687
Copy link
Copy link
Open
Labels
O-FrequentAffects or can be seen by most users regularly or impacts most users' first experienceAffects or can be seen by most users regularly or impacts most users' first experienceS-MinorBlocks non-critical functionality, workarounds exist.Blocks non-critical functionality, workarounds exist.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Description
Description:
Since MSC3912 has been implemented by #14260, we introduced 2 changes into the MSC for which we need to update this implementation :
- the new property
with_relations
has been renamedwith_rel_types
(to prevent us from introducing a new term ("relations") to refer to event relationships). Only the stable name is changed, we keep the existing unstable one. - we introduced a catch-all
"*"
value, which if found in the list means "any relation type"
There is one stuff missing:
The first Synapse PR (#14260) says:
This implementation is lacking a way to keep watch for incoming events that match the redaction criteria after the redaction request finishes, that'll come in a separate PR.
We have to decide if the backend team can work on this border use case by provided an additional PR. If not, we should remove this part from the MSC (details)
Metadata
Metadata
Assignees
Labels
O-FrequentAffects or can be seen by most users regularly or impacts most users' first experienceAffects or can be seen by most users regularly or impacts most users' first experienceS-MinorBlocks non-critical functionality, workarounds exist.Blocks non-critical functionality, workarounds exist.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.