Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Faster joins: check purge behavior is ok when in partial state #14859

Closed
Closed
Faster joins: check purge behavior is ok when in partial state#14859
Assignees
DMRobertson
Labels
A-Admin-APIA-Federated-Joinjoins over federation generally suckO-UncommonMost users are unlikely to come across this or unexpected workflowS-MinorBlocks non-critical functionality, workarounds exist.T-EnhancementNew features, changes in functionality, improvements in performance, or user-facing enhancements.
Milestone
Remaining faster remote join work
@MatMaul

Description

@MatMaul
MatMaul
opened on Jan 17, 2023

Purging a room with the admin API when we are in partial state should be handled gracefully.

We could reject the purge, or just wait for the full state and then do it.

Second approach is however not restart friendly: if we restart during a resync, the resync process will be resume but the purge will be ignored (? since purge v2 is async, to be checked).

relevant #synapse-dev conversation: https://matrix.to/#/!vcyiEtMVHIhWXcJAfl:sw1v.org/$vCxad2MgGfIiZYJOdscIrR6kY6H0aGc4jzc0MWYzXk4?via=matrix.org&via=element.io&via=envs.net

Metadata

Metadata

Assignees

Labels

A-Admin-APIA-Federated-Joinjoins over federation generally suckO-UncommonMost users are unlikely to come across this or unexpected workflowS-MinorBlocks non-critical functionality, workarounds exist.T-EnhancementNew features, changes in functionality, improvements in performance, or user-facing enhancements.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions