Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Hidden listener option tag #14746

Closed
#14803
Closed
Hidden listener option tag#14746
#14803
Labels
A-Docsthings relating to the documentationA-LoggingSynapse's logs (structured or otherwise). Not metrics.O-OccasionalAffects or can be seen by some users regularly or most users rarelyS-TolerableMinor significance, cosmetic issues, low or no impact to users.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.good first issueGood for newcomers
@dklimpel

Description

@dklimpel
dklimpel
opened on Dec 29, 2022

Description

I have seen an undocumented config option tag / site_tag in

synapse/synapse/app/homeserver.py

Lines 86 to 88 in 9af2be1

site_tag = listener_config.http_options.tag
if site_tag is None:
site_tag = str(port)

  • Is it used and only not good documented?
  • Or is it old an deprecated?
  • Does it make sense to document it in listener documentation?
  • And does it have other purposes than replacing the port with the tag in logging?

Origin: #187

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-Docsthings relating to the documentationA-LoggingSynapse's logs (structured or otherwise). Not metrics.O-OccasionalAffects or can be seen by some users regularly or most users rarelyS-TolerableMinor significance, cosmetic issues, low or no impact to users.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.good first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions