Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Include x_forwarded in workers sample config files #14653

@villepeh

Description

@villepeh

Description:

I didn't want to create a pull request on this yet because there's a chance I missed something.

I suppose almost everyone runs a reverse proxy when using workers that utilize a HTTP listener. However, none of the worker sample config files include the x_forwarded setting which reads the value of X-Forwarded-For.

If I understood it right, without setting x_forwarded on worker configs, the servers that have moved pretty much everything to the workers never get the users' actual IPs, showing 127.0.0.1 on all their sessions.

If the XFF "magic" is handled some other way with the workers then this issue is useless :) but if not, I can create a PR that'll add the setting to the relevant sample config files.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-ConfigConfiguration, or the documentation thereofA-Docsthings relating to the documentationA-WorkersProblems related to running Synapse in Worker Mode (or replication)O-OccasionalAffects or can be seen by some users regularly or most users rarelyS-TolerableMinor significance, cosmetic issues, low or no impact to users.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Z-Help-WantedWe know exactly how to fix this issue, and would be grateful for any contribution

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions