This repository was archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Include x_forwarded
in workers sample config files #14653
Copy link
Copy link
Closed
Labels
A-ConfigConfiguration, or the documentation thereofConfiguration, or the documentation thereofA-Docsthings relating to the documentationthings relating to the documentationA-WorkersProblems related to running Synapse in Worker Mode (or replication)Problems related to running Synapse in Worker Mode (or replication)O-OccasionalAffects or can be seen by some users regularly or most users rarelyAffects or can be seen by some users regularly or most users rarelyS-TolerableMinor significance, cosmetic issues, low or no impact to users.Minor significance, cosmetic issues, low or no impact to users.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Z-Help-WantedWe know exactly how to fix this issue, and would be grateful for any contributionWe know exactly how to fix this issue, and would be grateful for any contribution
Description
Description:
I didn't want to create a pull request on this yet because there's a chance I missed something.
I suppose almost everyone runs a reverse proxy when using workers that utilize a HTTP listener. However, none of the worker sample config files include the x_forwarded
setting which reads the value of X-Forwarded-For.
If I understood it right, without setting x_forwarded
on worker configs, the servers that have moved pretty much everything to the workers never get the users' actual IPs, showing 127.0.0.1 on all their sessions.
If the XFF "magic" is handled some other way with the workers then this issue is useless :) but if not, I can create a PR that'll add the setting to the relevant sample config files.
Metadata
Metadata
Assignees
Labels
A-ConfigConfiguration, or the documentation thereofConfiguration, or the documentation thereofA-Docsthings relating to the documentationthings relating to the documentationA-WorkersProblems related to running Synapse in Worker Mode (or replication)Problems related to running Synapse in Worker Mode (or replication)O-OccasionalAffects or can be seen by some users regularly or most users rarelyAffects or can be seen by some users regularly or most users rarelyS-TolerableMinor significance, cosmetic issues, low or no impact to users.Minor significance, cosmetic issues, low or no impact to users.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Z-Help-WantedWe know exactly how to fix this issue, and would be grateful for any contributionWe know exactly how to fix this issue, and would be grateful for any contribution