Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

EventID incorrectly inherits from DomainSpecificString #14638

Open
Open
EventID incorrectly inherits from DomainSpecificString#14638
Labels
O-OccasionalAffects or can be seen by some users regularly or most users rarelyS-MinorBlocks non-critical functionality, workarounds exist.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.Z-CleanupThings we want to get rid of, but aren't actively causing pain
@clokep

Description

@clokep
clokep
opened on Dec 7, 2022

Not super happy with the startswith but EventID.is_valid is broken for non-V1/2 event IDs so unsure how to proceed.

Originally posted by @Fizzadar in #14632 (comment)

Modern event IDs are now hashes and do not include a domain name, so they shouldn't inherit from DomainSepcificString.

Metadata

Metadata

Assignees

No one assigned

    Labels

    O-OccasionalAffects or can be seen by some users regularly or most users rarelyS-MinorBlocks non-critical functionality, workarounds exist.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.Z-CleanupThings we want to get rid of, but aren't actively causing pain

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions