Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

synapse does not escape forward slashes in key IDs when making a federation key/v2/server/... request #14488

Closed
#14490
Closed
synapse does not escape forward slashes in key IDs when making a federation key/v2/server/... request#14488
#14490
Assignees
DMRobertson
@DMRobertson

Description

@DMRobertson
DMRobertson
opened on Nov 18, 2022

synapse/synapse/crypto/keyring.py

Lines 857 to 874 in d8cc86e

response = await self.client.get_json(
destination=server_name,
path="/_matrix/key/v2/server/"
+ urllib.parse.quote(requested_key_id),
ignore_backoff=True,
# we only give the remote server 10s to respond. It should be an
# easy request to handle, so if it doesn't reply within 10s, it's
# probably not going to.
#
# Furthermore, when we are acting as a notary server, we cannot
# wait all day for all of the origin servers, as the requesting
# server will otherwise time out before we can respond.
#
# (Note that get_json may make 4 attempts, so this can still take
# almost 45 seconds to fetch the headers, plus up to another 60s to
# read the response).
timeout=10000,
)

urllib.parse.quote doesn't escape slashes by default: because it expects to given an entire url path

ouchie

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions