The current situation is that we block waiting for full state:

  synapse_main |   File "/usr/local/lib/python3.9/site-packages/synapse/rest/client/directory.py", line 91, in on_PUT
  synapse_main |     await self.directory_handler.create_association(
  synapse_main |   File "/usr/local/lib/python3.9/site-packages/synapse/handlers/directory.py", line 175, in create_association
  synapse_main |     await self._create_association(room_alias, room_id, servers, creator=user_id)
  synapse_main |   File "/usr/local/lib/python3.9/site-packages/synapse/handlers/directory.py", line 88, in _create_association
  synapse_main |     servers = await self._storage_controllers.state.get_current_hosts_in_room(
  synapse_main |   File "/usr/local/lib/python3.9/site-packages/synapse/storage/controllers/state.py", line 539, in get_current_hosts_in_room
  synapse_main |     await self._partial_state_room_tracker.await_full_state(room_id)
  synapse_main |   File "/usr/local/lib/python3.9/site-packages/synapse/logging/opentracing.py", line 889, in _wrapper
  synapse_main |     return await func(*args, **kwargs)  # type: ignore[misc]
  synapse_main |   File "/usr/local/lib/python3.9/site-packages/synapse/storage/util/partial_state_events_tracker.py", line 172, in await_full_state
  synapse_main |     logger.info(

So we need to change that behaviour.

Also: do we persist the list of servers we get from a send_join response? Presumably this is what partial_state_rooms_servers is for?

Edit: ahh yes, get_partial_state_servers_at_join:

synapse/synapse/storage/databases/main/room.py

Lines 1152 to 1167 in c3a4780

    
               @cached(iterable=True) 
        
               async def get_partial_state_servers_at_join(self, room_id: str) -> Sequence[str]: 
        
                   """Gets the list of servers in a partial state room at the time we joined it. 
        
                   Returns: 
        
                       The `servers_in_room` list from the `/send_join` response for partial state 
        
                       rooms. May not be accurate or complete, as it comes from a remote 
        
                       homeserver. 
        
                       An empty list for full state rooms. 
        
                   """ 
        
                   return await self.db_pool.simple_select_onecol( 
        
                       "partial_state_rooms_servers", 
        
                       keyvalues={"room_id": room_id}, 
        
                       retcol="server_name", 
        
                       desc="get_partial_state_servers_at_join", 
        
                   )

	@cached(iterable=True)
	async def get_partial_state_servers_at_join(self, room_id: str) -> Sequence[str]:
	"""Gets the list of servers in a partial state room at the time we joined it.

	Returns:
	The `servers_in_room` list from the `/send_join` response for partial state
	rooms. May not be accurate or complete, as it comes from a remote
	homeserver.
	An empty list for full state rooms.
	"""
	return await self.db_pool.simple_select_onecol(
	"partial_state_rooms_servers",
	keyvalues={"room_id": room_id},
	retcol="server_name",
	desc="get_partial_state_servers_at_join",
	)

Uh oh!

Faster joins: room alias server list may be incomplete #13287

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions