Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Drop support for calling /_matrix/client/v3/account/3pid/bind without an id_access_token #13201

Closed
#13239
Closed
Drop support for calling /_matrix/client/v3/account/3pid/bind without an id_access_token#13201
#13239
Labels
A-Spec-Complianceplaces where synapse does not conform to the specP3(OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patchesT-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.Z-Help-WantedWe know exactly how to fix this issue, and would be grateful for any contribution
@richvdh

Description

@richvdh
richvdh
opened on Jul 6, 2022

The spec has required an id_access_token param for /account/3pid/bind ever since it was introduced to the spec in matrix-org/matrix-spec-proposals#2328.

We currently accept requests without an id_access_token, and then call /_matrix/identity/api/v1/3pid/bind, which was removed from the spec over a year ago (msc2713).

Instead, we should simply reject any requests that do not pass an id_access_token.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-Spec-Complianceplaces where synapse does not conform to the specP3(OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patchesT-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.Z-Help-WantedWe know exactly how to fix this issue, and would be grateful for any contribution

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions