This repository was archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Generalize tracking whenever we fail to fetch or process a federated event #13700
Copy link
Copy link
Open
Labels
A-FederationA-Messages-Endpoint/messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill)/messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill)T-EnhancementNew features, changes in functionality, improvements in performance, or user-facing enhancements.New features, changes in functionality, improvements in performance, or user-facing enhancements.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Milestone
Description
Follow-up to #13621. As discussed at #13589 (comment) and #13589 (comment)
- Track when we fail to process a pulled event over federation
-
Maybe: Track when we ask/backfill
from a certain event but the/backfill
response doesn't include it - Track when an event signature check fails (
_check_sigs_and_hash_and_fetch_one
,Signature on retrieved event was invalid
) - Track when we fail to fetch or process
/event/{eventId}
- Track when we fail to fetch or process
/event_auth/{roomId}/{eventId}
- Track when we fail to fetch or process
/state/{roomId}?event_id=$xxx
- Track when we fail to fetch or process
/state_ids/{roomId}?event_id=$xxx
- Track when we fail process an event from
/get_missing_events
- Can we also consider soft-failed events because of the spam checker?
We will need to add more record_event_failed_backfill_attempt
calls for the failed to fetch scenarios though.
Metadata
Metadata
Assignees
Labels
A-FederationA-Messages-Endpoint/messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill)/messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill)T-EnhancementNew features, changes in functionality, improvements in performance, or user-facing enhancements.New features, changes in functionality, improvements in performance, or user-facing enhancements.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.